Changeset 243330 in webkit

Timestamp:

Mar 21, 2019, 2:36:26 PM (7 years ago)

Author:

rmorisset@apple.com

Message:

B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes
​https://bugs.webkit.org/show_bug.cgi?id=196014

Reviewed by Keith Miller.

B3::Opcode has less than one hundred cases, so it can easily fit in one byte (from two currently)
This shrinks B3::Kind from 4 bytes to 2 (by removing the byte of padding at the end).
This in turns eliminate padding from B3::Value, shrinking it by 8 bytes (out of 80).

• b3/B3Opcode.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/B3Opcode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-21  Robin Morisset  <rmorisset@apple.com>
+
+        B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=196014
+
+        Reviewed by Keith Miller.
+
+        B3::Opcode has less than one hundred cases, so it can easily fit in one byte (from two currently)
+        This shrinks B3::Kind from 4 bytes to 2 (by removing the byte of padding at the end).
+        This in turns eliminate padding from B3::Value, shrinking it by 8 bytes (out of 80).
+
+        * b3/B3Opcode.h:
+
 2019-03-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/JavaScriptCore/b3/B3Opcode.h

@@ -38 +38 @@
 // would be used in simple IRs. See B3Kind.h.
 
-enum Opcode : int16_t {
+enum Opcode : uint8_t {
     // A no-op that returns Void, useful for when you want to remove a value.
     Nop,