Changeset 243332 in webkit

Timestamp:

Mar 21, 2019, 2:46:08 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Generate status-bubble hover-over messages (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=195680
<rdar://problem/48903534>

Unreviewed infrastructure fix.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -84 +84 @@
         elif build.result == Buildbot.EXCEPTION:
             bubble['state'] = 'error'
-            bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+            bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         elif build.result == Buildbot.RETRY:
             bubble['state'] = 'provisional-fail'
-            bubble['details_message'] += ('Build is being retried. Recent messages:\n\n'
+            bubble['details_message'] = ('Build is being retried. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         elif build.result == Buildbot.CANCELLED:
             bubble['state'] = 'provisional-fail'
-            bubble['details_message'] += ('Build was cancelled. Recent messages:\n\n'
+            bubble['details_message'] = ('Build was cancelled. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         else:
             bubble['state'] = 'error'
-            bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+            bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-21  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=195680
+        <rdar://problem/48903534>
+
+        Unreviewed infrastructure fix.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
+
 2019-03-21  Andy Estes  <aestes@apple.com>