Changeset 243378 in webkit

Timestamp:

Mar 22, 2019, 9:03:31 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r243094): Automation: browser crash in WebAutomationSession::exitFullscreenWindowForPage()
​https://bugs.webkit.org/show_bug.cgi?id=196140

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-03-22
Reviewed by Chris Dumez.

Since r243094, the WebPageProxy fullscreen manager is not created in the constructor, but once the page has a
process launched.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::exitFullscreenWindowForPage): Null check WebPageProxy::fullScreenManager() before
using it.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/WebAutomationSession.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r243094): Automation: browser crash in WebAutomationSession::exitFullscreenWindowForPage()
+        https://bugs.webkit.org/show_bug.cgi?id=196140
+
+        Reviewed by Chris Dumez.
+
+        Since r243094, the WebPageProxy fullscreen manager is not created in the constructor, but once the page has a
+        process launched.
+
+        * UIProcess/Automation/WebAutomationSession.cpp:
+        (WebKit::WebAutomationSession::exitFullscreenWindowForPage): Null check WebPageProxy::fullScreenManager() before
+        using it.
+
 2019-03-22  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp

@@ -599 +599 @@
 #if ENABLE(FULLSCREEN_API)
     ASSERT(!m_windowStateTransitionCallback);
-    if (!page.fullScreenManager()->isFullScreen()) {
+    if (!page.fullScreenManager() || !page.fullScreenManager()->isFullScreen()) {
         completionHandler();
         return;