Changeset 243385 in webkit

Timestamp:

Mar 22, 2019, 10:02:13 AM (7 years ago)

Author:

Chris Dumez

Message:

[ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
​https://bugs.webkit.org/show_bug.cgi?id=195348
<rdar://problem/48622090>

Reviewed by Alex Christensen.

Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
to NO when test.options().shouldIgnoreMetaViewport is false.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformConfigureViewForTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/ios/TestControllerIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-22  Chris Dumez  <cdumez@apple.com>
+
+        [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
+        https://bugs.webkit.org/show_bug.cgi?id=195348
+        <rdar://problem/48622090>
+
+        Reviewed by Alex Christensen.
+
+        Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
+        to NO when test.options().shouldIgnoreMetaViewport is false.
+
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::TestController::platformConfigureViewForTest):
+
 2019-03-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm

@@ -179 +179 @@
     TestRunnerWKWebView *webView = mainWebView()->platformView();
 
-    if (test.options().shouldIgnoreMetaViewport)
-        webView.configuration.preferences._shouldIgnoreMetaViewport = YES;
+    webView.configuration.preferences._shouldIgnoreMetaViewport = test.options().shouldIgnoreMetaViewport;
 
     CGRect screenBounds = [UIScreen mainScreen].bounds;