Changeset 243401 in webkit

Timestamp:

Mar 22, 2019, 3:11:41 PM (7 years ago)

Author:

youenn@apple.com

Message:

storage/indexeddb/closed-cursor-private.html is crashing on debug
​https://bugs.webkit.org/show_bug.cgi?id=196101

Reviewed by Alex Christensen.

In case of immediate close for user delete, the transaction might be deleted.
If the request for space is pending, it will be executed with an error as parameter.
In that case, the call to didCommitTransaction will not find any existing transaction.
Speculative fix, test should no longer crash.

• Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-22  Youenn Fablet  <youenn@apple.com>
+
+        storage/indexeddb/closed-cursor-private.html is crashing on debug
+        https://bugs.webkit.org/show_bug.cgi?id=196101
+
+        Reviewed by Alex Christensen.
+
+        In case of immediate close for user delete, the transaction might be deleted.
+        If the request for space is pending, it will be executed with an error as parameter.
+        In that case, the call to didCommitTransaction will not find any existing transaction.
+        Speculative fix, test should no longer crash.
+
+        * Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):
+
 2019-03-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp

@@ -182 +182 @@
     auto transactionIdentifier = transaction.info().identifier();
 
-    ASSERT(m_transactionMap.contains(transactionIdentifier));
+    ASSERT(m_transactionMap.contains(transactionIdentifier) || !error.isNull());
     m_transactionMap.remove(transactionIdentifier);