Changeset 243402 in webkit

Timestamp:

Mar 22, 2019, 3:12:32 PM (7 years ago)

Author:

youenn@apple.com

Message:

REGRESSION: Flaky ASSERTION FAILED: !m_killed seen with http/tests/security/cross-origin-worker-indexeddb.html
​https://bugs.webkit.org/show_bug.cgi?id=196024
<rdar://problem/49117272>

Reviewed by Alexey Proskuryakov.

Do not proceed with opening the database if it is being closed.
Speculative fix, this should stop making test crashing on bots.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/UniqueIDBDatabase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-22  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION: Flaky ASSERTION FAILED: !m_killed seen with http/tests/security/cross-origin-worker-indexeddb.html
+        https://bugs.webkit.org/show_bug.cgi?id=196024
+        <rdar://problem/49117272>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Do not proceed with opening the database if it is being closed.
+        Speculative fix, this should stop making test crashing on bots.
+
+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
+
 2019-03-22  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp

@@ -221 +221 @@
                     return;
 
+                if (m_owningPointerForClose)
+                    return;
+
                 switch (decision) {
                 case StorageQuotaManager::Decision::Deny: {