Changeset 243413 in webkit

Timestamp:

Mar 23, 2019, 1:47:47 PM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Check if the transitioned content is visible at onAnimationEnd
​https://bugs.webkit.org/show_bug.cgi?id=196171

Reviewed by Simon Fraser.

Source/WebCore:

At onAnimationEnd we don't yet have the final computed style for the transitioned content.
However the current state (before computing the final style) might already be qualified to be visible.
Introduce "CompletedTransition" to indicate that the transition is all set as far observing is concerned
(as opposed to "EndedTransition" where we still need to observe the content for the final style change).

Test: fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::didFinishTransition):
(WebCore::ContentChangeObserver::adjustObservedState):

• page/ios/ContentChangeObserver.h:

LayoutTests:

• fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end-expected.txt: Added.
• fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/ios/ContentChangeObserver.cpp (modified) (3 diffs)
• Source/WebCore/page/ios/ContentChangeObserver.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-23  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Check if the transitioned content is visible at onAnimationEnd
+        https://bugs.webkit.org/show_bug.cgi?id=196171
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html: Added.
+
 2019-03-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-23  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Check if the transitioned content is visible at onAnimationEnd
+        https://bugs.webkit.org/show_bug.cgi?id=196171
+
+        Reviewed by Simon Fraser.
+
+        At onAnimationEnd we don't yet have the final computed style for the transitioned content.
+        However the current state (before computing the final style) might already be qualified to be visible.
+        Introduce "CompletedTransition" to indicate that the transition is all set as far observing is concerned
+        (as opposed to "EndedTransition" where we still need to observe the content for the final style change).
+
+        Test: fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html
+
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::didFinishTransition):
+        (WebCore::ContentChangeObserver::adjustObservedState):
+        * page/ios/ContentChangeObserver.h:
+
 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -153 +153 @@
     LOG_WITH_STREAM(ContentObservation, stream << "didFinishTransition: transition finished (" << &element << ").");
 
-    adjustObservedState(Event::EndedTransition);
+    adjustObservedState(isConsideredHidden(element) ? Event::EndedTransition : Event::CompletedTransition);
 }
 
@@ -435 +435 @@
     case Event::EndedTransition:
         // onAnimationEnd can be called while in the middle of resolving the document (synchronously) or
-        // asynchronously right before the style update is issued.
+        // asynchronously right before the style update is issued. It also means we don't know whether this animation ends up producing visible content yet. 
         if (m_document.inStyleRecalc()) {
             // We need to start observing this style change synchronously.
@@ -441 +441 @@
         } else
             setShouldObserveNextStyleRecalc(true);
+        break;
+    case Event::CompletedTransition:
+        // Set visibility flag on and report visible change synchronously or asynchronously depending whether we are in the middle of style recalc.
+        contentVisibilityDidChange();
+        if (m_document.inStyleRecalc())
+            m_isInObservedStyleRecalc = true;
+        else if (!isObservationTimeWindowActive())
+            adjustStateAndNotifyContentChangeIfNeeded();
         break;
     case Event::EndedFixedObservationTimeWindow:

trunk/Source/WebCore/page/ios/ContentChangeObserver.h

@@ -174 +174 @@
         AddedTransition,
         EndedTransition,
+        CompletedTransition,
         CanceledTransition,
         StartedFixedObservationTimeWindow,