Changeset 243415 in webkit

Timestamp:

Mar 23, 2019, 2:07:51 PM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Taping on a form control should always result in click.
​https://bugs.webkit.org/show_bug.cgi?id=196177

Reviewed by Simon Fraser.

Source/WebKit:

This patch enures that we send a synthetic click when the traget node is a form control (button, edit field etc) even if
the mousemove brings up some hover content.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

LayoutTests:

• fast/events/touch/ios/content-observation/tap-on-input-type-button-element-expected.txt: Added.
• fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html: Added.
• fast/events/touch/ios/content-observation/tap-on-input-type-text-element-expected.txt: Added.
• fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/content-observation/tap-on-input-type-button-element-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html (added)
• LayoutTests/fast/events/touch/ios/content-observation/tap-on-input-type-text-element-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-23  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Taping on a form control should always result in click.
+        https://bugs.webkit.org/show_bug.cgi?id=196177
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/touch/ios/content-observation/tap-on-input-type-button-element-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html: Added.
+        * fast/events/touch/ios/content-observation/tap-on-input-type-text-element-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html: Added.
+
 2019-03-23  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-23  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Taping on a form control should always result in click.
+        https://bugs.webkit.org/show_bug.cgi?id=196177
+
+        Reviewed by Simon Fraser.
+
+        This patch enures that we send a synthetic click when the traget node is a form control (button, edit field etc) even if
+        the mousemove brings up some hover content.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::handleSyntheticClick):
+
 2019-03-23  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -580 +580 @@
         return;
 
+    if (is<HTMLFormControlElement>(nodeRespondingToClick)) {
+        LOG(ContentObservation, "handleSyntheticClick: Target node is a form control -> click.");
+        completeSyntheticClick(nodeRespondingToClick, location, modifiers, WebCore::OneFingerTap);
+        return;
+    }
     auto& contentChangeObserver = respondingDocument.contentChangeObserver();
     auto observedContentChange = contentChangeObserver.observedContentChange();