⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 243435 in webkit


Ignore:
Timestamp:
Mar 25, 2019, 3:30:55 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Reflect HTMLLinkElement.as according to the spec
​https://bugs.webkit.org/show_bug.cgi?id=196189

Patch by Rob Buis <​rbuis@igalia.com> on 2019-03-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test result and import reflected-as-value.html.

  • web-platform-tests/html/dom/reflection-metadata-expected.txt:
  • web-platform-tests/preload/reflected-as-value-expected.txt: Added.
  • web-platform-tests/preload/reflected-as-value.html: Added.

Source/WebCore:

The 'as' attribute is an enumerated attribute [1] and should
reflect using a finite set of keywords, so lowercase the as getter
to match the defined set of destinations [2].

Test: imported/w3c/web-platform-tests/preload/reflected-as-value.html

[1] ​https://html.spec.whatwg.org/#enumerated-attribute
[2] ​https://fetch.spec.whatwg.org/#concept-request-destination

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):

LayoutTests:

Update improved test result.

  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:
Location:
trunk
Files:
3 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r243433 r243435  
     12019-03-25  Rob Buis  <rbuis@igalia.com>
     2
     3        Reflect HTMLLinkElement.as according to the spec
     4        https://bugs.webkit.org/show_bug.cgi?id=196189
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Update improved test result.
     9
     10        * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:
     11
    1122019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r243432 r243435  
     12019-03-25  Rob Buis  <rbuis@igalia.com>
     2
     3        Reflect HTMLLinkElement.as according to the spec
     4        https://bugs.webkit.org/show_bug.cgi?id=196189
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Update improved test result and import reflected-as-value.html.
     9
     10        * web-platform-tests/html/dom/reflection-metadata-expected.txt:
     11        * web-platform-tests/preload/reflected-as-value-expected.txt: Added.
     12        * web-platform-tests/preload/reflected-as-value.html: Added.
     13
    1142019-03-25  Manuel Rego Casasnovas  <rego@igalia.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt

    r230445 r243435  
    11851185PASS link.as: setAttribute() to "fetch\0"
    11861186PASS link.as: setAttribute() to "etch"
    1187 FAIL link.as: setAttribute() to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
     1187PASS link.as: setAttribute() to "FETCH"
    11881188PASS link.as: setAttribute() to "audio"
    11891189PASS link.as: setAttribute() to "xaudio"
    11901190PASS link.as: setAttribute() to "audio\0"
    11911191PASS link.as: setAttribute() to "udio"
    1192 FAIL link.as: setAttribute() to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
     1192PASS link.as: setAttribute() to "AUDIO"
    11931193FAIL link.as: setAttribute() to "document" assert_equals: IDL get expected "document" but got ""
    11941194PASS link.as: setAttribute() to "xdocument"
    … …  
    12051205PASS link.as: setAttribute() to "font\0"
    12061206PASS link.as: setAttribute() to "ont"
    1207 FAIL link.as: setAttribute() to "FONT" assert_equals: IDL get expected "font" but got "FONT"
     1207PASS link.as: setAttribute() to "FONT"
    12081208PASS link.as: setAttribute() to "image"
    12091209PASS link.as: setAttribute() to "ximage"
    12101210PASS link.as: setAttribute() to "image\0"
    12111211PASS link.as: setAttribute() to "mage"
    1212 FAIL link.as: setAttribute() to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
     1212PASS link.as: setAttribute() to "IMAGE"
    12131213FAIL link.as: setAttribute() to "manifest" assert_equals: IDL get expected "manifest" but got ""
    12141214PASS link.as: setAttribute() to "xmanifest"
    … …  
    12301230PASS link.as: setAttribute() to "script\0"
    12311231PASS link.as: setAttribute() to "cript"
    1232 FAIL link.as: setAttribute() to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
     1232PASS link.as: setAttribute() to "SCRIPT"
    12331233FAIL link.as: setAttribute() to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
    12341234PASS link.as: setAttribute() to "xsharedworker"
    … …  
    12411241PASS link.as: setAttribute() to "style\0"
    12421242PASS link.as: setAttribute() to "tyle"
    1243 FAIL link.as: setAttribute() to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
     1243PASS link.as: setAttribute() to "STYLE"
    12441244PASS link.as: setAttribute() to "track"
    12451245PASS link.as: setAttribute() to "xtrack"
    12461246PASS link.as: setAttribute() to "track\0"
    12471247PASS link.as: setAttribute() to "rack"
    1248 FAIL link.as: setAttribute() to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
     1248PASS link.as: setAttribute() to "TRACK"
    12491249PASS link.as: setAttribute() to "tracK"
    12501250PASS link.as: setAttribute() to "video"
    … …  
    12521252PASS link.as: setAttribute() to "video\0"
    12531253PASS link.as: setAttribute() to "ideo"
    1254 FAIL link.as: setAttribute() to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
     1254PASS link.as: setAttribute() to "VIDEO"
    12551255FAIL link.as: setAttribute() to "worker" assert_equals: IDL get expected "worker" but got ""
    12561256PASS link.as: setAttribute() to "xworker"
    … …  
    12831283PASS link.as: IDL set to "fetch\0"
    12841284PASS link.as: IDL set to "etch"
    1285 FAIL link.as: IDL set to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
     1285PASS link.as: IDL set to "FETCH"
    12861286PASS link.as: IDL set to "audio"
    12871287PASS link.as: IDL set to "xaudio"
    12881288PASS link.as: IDL set to "audio\0"
    12891289PASS link.as: IDL set to "udio"
    1290 FAIL link.as: IDL set to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
     1290PASS link.as: IDL set to "AUDIO"
    12911291FAIL link.as: IDL set to "document" assert_equals: IDL get expected "document" but got ""
    12921292PASS link.as: IDL set to "xdocument"
    … …  
    13031303PASS link.as: IDL set to "font\0"
    13041304PASS link.as: IDL set to "ont"
    1305 FAIL link.as: IDL set to "FONT" assert_equals: IDL get expected "font" but got "FONT"
     1305PASS link.as: IDL set to "FONT"
    13061306PASS link.as: IDL set to "image"
    13071307PASS link.as: IDL set to "ximage"
    13081308PASS link.as: IDL set to "image\0"
    13091309PASS link.as: IDL set to "mage"
    1310 FAIL link.as: IDL set to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
     1310PASS link.as: IDL set to "IMAGE"
    13111311FAIL link.as: IDL set to "manifest" assert_equals: IDL get expected "manifest" but got ""
    13121312PASS link.as: IDL set to "xmanifest"
    … …  
    13281328PASS link.as: IDL set to "script\0"
    13291329PASS link.as: IDL set to "cript"
    1330 FAIL link.as: IDL set to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
     1330PASS link.as: IDL set to "SCRIPT"
    13311331FAIL link.as: IDL set to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
    13321332PASS link.as: IDL set to "xsharedworker"
    … …  
    13391339PASS link.as: IDL set to "style\0"
    13401340PASS link.as: IDL set to "tyle"
    1341 FAIL link.as: IDL set to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
     1341PASS link.as: IDL set to "STYLE"
    13421342PASS link.as: IDL set to "track"
    13431343PASS link.as: IDL set to "xtrack"
    13441344PASS link.as: IDL set to "track\0"
    13451345PASS link.as: IDL set to "rack"
    1346 FAIL link.as: IDL set to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
     1346PASS link.as: IDL set to "TRACK"
    13471347PASS link.as: IDL set to "tracK"
    13481348PASS link.as: IDL set to "video"
    … …  
    13501350PASS link.as: IDL set to "video\0"
    13511351PASS link.as: IDL set to "ideo"
    1352 FAIL link.as: IDL set to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
     1352PASS link.as: IDL set to "VIDEO"
    13531353FAIL link.as: IDL set to "worker" assert_equals: IDL get expected "worker" but got ""
    13541354PASS link.as: IDL set to "xworker"

  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt

    r230445 r243435  
    11851185PASS link.as: setAttribute() to "fetch\0"
    11861186PASS link.as: setAttribute() to "etch"
    1187 FAIL link.as: setAttribute() to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
     1187PASS link.as: setAttribute() to "FETCH"
    11881188PASS link.as: setAttribute() to "audio"
    11891189PASS link.as: setAttribute() to "xaudio"
    11901190PASS link.as: setAttribute() to "audio\0"
    11911191PASS link.as: setAttribute() to "udio"
    1192 FAIL link.as: setAttribute() to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
     1192PASS link.as: setAttribute() to "AUDIO"
    11931193FAIL link.as: setAttribute() to "document" assert_equals: IDL get expected "document" but got ""
    11941194PASS link.as: setAttribute() to "xdocument"
    … …  
    12051205PASS link.as: setAttribute() to "font\0"
    12061206PASS link.as: setAttribute() to "ont"
    1207 FAIL link.as: setAttribute() to "FONT" assert_equals: IDL get expected "font" but got "FONT"
     1207PASS link.as: setAttribute() to "FONT"
    12081208PASS link.as: setAttribute() to "image"
    12091209PASS link.as: setAttribute() to "ximage"
    12101210PASS link.as: setAttribute() to "image\0"
    12111211PASS link.as: setAttribute() to "mage"
    1212 FAIL link.as: setAttribute() to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
     1212PASS link.as: setAttribute() to "IMAGE"
    12131213FAIL link.as: setAttribute() to "manifest" assert_equals: IDL get expected "manifest" but got ""
    12141214PASS link.as: setAttribute() to "xmanifest"
    … …  
    12301230PASS link.as: setAttribute() to "script\0"
    12311231PASS link.as: setAttribute() to "cript"
    1232 FAIL link.as: setAttribute() to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
     1232PASS link.as: setAttribute() to "SCRIPT"
    12331233FAIL link.as: setAttribute() to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
    12341234PASS link.as: setAttribute() to "xsharedworker"
    … …  
    12411241PASS link.as: setAttribute() to "style\0"
    12421242PASS link.as: setAttribute() to "tyle"
    1243 FAIL link.as: setAttribute() to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
     1243PASS link.as: setAttribute() to "STYLE"
    12441244PASS link.as: setAttribute() to "track"
    12451245PASS link.as: setAttribute() to "xtrack"
    12461246PASS link.as: setAttribute() to "track\0"
    12471247PASS link.as: setAttribute() to "rack"
    1248 FAIL link.as: setAttribute() to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
     1248PASS link.as: setAttribute() to "TRACK"
    12491249PASS link.as: setAttribute() to "tracK"
    12501250PASS link.as: setAttribute() to "video"
    … …  
    12521252PASS link.as: setAttribute() to "video\0"
    12531253PASS link.as: setAttribute() to "ideo"
    1254 FAIL link.as: setAttribute() to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
     1254PASS link.as: setAttribute() to "VIDEO"
    12551255FAIL link.as: setAttribute() to "worker" assert_equals: IDL get expected "worker" but got ""
    12561256PASS link.as: setAttribute() to "xworker"
    … …  
    12831283PASS link.as: IDL set to "fetch\0"
    12841284PASS link.as: IDL set to "etch"
    1285 FAIL link.as: IDL set to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
     1285PASS link.as: IDL set to "FETCH"
    12861286PASS link.as: IDL set to "audio"
    12871287PASS link.as: IDL set to "xaudio"
    12881288PASS link.as: IDL set to "audio\0"
    12891289PASS link.as: IDL set to "udio"
    1290 FAIL link.as: IDL set to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
     1290PASS link.as: IDL set to "AUDIO"
    12911291FAIL link.as: IDL set to "document" assert_equals: IDL get expected "document" but got ""
    12921292PASS link.as: IDL set to "xdocument"
    … …  
    13031303PASS link.as: IDL set to "font\0"
    13041304PASS link.as: IDL set to "ont"
    1305 FAIL link.as: IDL set to "FONT" assert_equals: IDL get expected "font" but got "FONT"
     1305PASS link.as: IDL set to "FONT"
    13061306PASS link.as: IDL set to "image"
    13071307PASS link.as: IDL set to "ximage"
    13081308PASS link.as: IDL set to "image\0"
    13091309PASS link.as: IDL set to "mage"
    1310 FAIL link.as: IDL set to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
     1310PASS link.as: IDL set to "IMAGE"
    13111311FAIL link.as: IDL set to "manifest" assert_equals: IDL get expected "manifest" but got ""
    13121312PASS link.as: IDL set to "xmanifest"
    … …  
    13281328PASS link.as: IDL set to "script\0"
    13291329PASS link.as: IDL set to "cript"
    1330 FAIL link.as: IDL set to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
     1330PASS link.as: IDL set to "SCRIPT"
    13311331FAIL link.as: IDL set to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
    13321332PASS link.as: IDL set to "xsharedworker"
    … …  
    13391339PASS link.as: IDL set to "style\0"
    13401340PASS link.as: IDL set to "tyle"
    1341 FAIL link.as: IDL set to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
     1341PASS link.as: IDL set to "STYLE"
    13421342PASS link.as: IDL set to "track"
    13431343PASS link.as: IDL set to "xtrack"
    13441344PASS link.as: IDL set to "track\0"
    13451345PASS link.as: IDL set to "rack"
    1346 FAIL link.as: IDL set to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
     1346PASS link.as: IDL set to "TRACK"
    13471347PASS link.as: IDL set to "tracK"
    13481348PASS link.as: IDL set to "video"
    … …  
    13501350PASS link.as: IDL set to "video\0"
    13511351PASS link.as: IDL set to "ideo"
    1352 FAIL link.as: IDL set to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
     1352PASS link.as: IDL set to "VIDEO"
    13531353FAIL link.as: IDL set to "worker" assert_equals: IDL get expected "worker" but got ""
    13541354PASS link.as: IDL set to "xworker"

  • trunk/Source/WebCore/ChangeLog

    r243433 r243435  
     12019-03-25  Rob Buis  <rbuis@igalia.com>
     2
     3        Reflect HTMLLinkElement.as according to the spec
     4        https://bugs.webkit.org/show_bug.cgi?id=196189
     5
     6        Reviewed by Youenn Fablet.
     7
     8        The 'as' attribute is an enumerated attribute [1] and should
     9        reflect using a finite set of keywords, so lowercase the as getter
     10        to match the defined set of destinations [2].
     11
     12        Test: imported/w3c/web-platform-tests/preload/reflected-as-value.html
     13
     14        [1] https://html.spec.whatwg.org/#enumerated-attribute
     15        [2] https://fetch.spec.whatwg.org/#concept-request-destination
     16
     17        * html/HTMLLinkElement.cpp:
     18        (WebCore::HTMLLinkElement::as const):
     19
    1202019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
    221

  • trunk/Source/WebCore/html/HTMLLinkElement.cpp

    r239427 r243435  
    246246#endif
    247247        || equalLettersIgnoringASCIICase(as, "font"))
    248         return as;
     248        return as.convertToASCIILowercase();
    249249    return String();
    250250}
Note: See TracChangeset for help on using the changeset viewer.