Changeset 243451 in webkit

Timestamp:

Mar 25, 2019, 1:43:47 PM (7 years ago)

Author:

eric.carlson@apple.com

Message:

Delete MetadataPreloadingNotPermitted, it is unused
​https://bugs.webkit.org/show_bug.cgi?id=196202
<rdar://problem/49213611>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, the flat was unused except in an existing test that was removed.

• html/MediaElementSession.cpp:

(WebCore::restrictionNames):
(WebCore::MediaElementSession::effectivePreloadForElement const):

• html/MediaElementSession.h:
• platform/graphics/cg/UTIRegistry.cpp:

(WebCore::defaultSupportedImageTypes):

• testing/Internals.cpp:

(WebCore::Internals::setMediaElementRestrictions):

LayoutTests:

• media/video-restricted-no-preload-metadata-expected.txt: Removed.
• media/video-restricted-no-preload-metadata.html: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/video-restricted-no-preload-metadata-expected.txt (deleted)
• LayoutTests/media/video-restricted-no-preload-metadata.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/MediaElementSession.cpp (modified) (2 diffs)
• Source/WebCore/html/MediaElementSession.h (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-25  Eric Carlson  <eric.carlson@apple.com>
+
+        Delete MetadataPreloadingNotPermitted, it is unused
+        https://bugs.webkit.org/show_bug.cgi?id=196202
+        <rdar://problem/49213611>
+
+        Reviewed by Jer Noble.
+
+        * media/video-restricted-no-preload-metadata-expected.txt: Removed.
+        * media/video-restricted-no-preload-metadata.html: Removed.
+
 2019-03-25  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-25  Eric Carlson  <eric.carlson@apple.com>
+
+        Delete MetadataPreloadingNotPermitted, it is unused
+        https://bugs.webkit.org/show_bug.cgi?id=196202
+        <rdar://problem/49213611>
+
+        Reviewed by Jer Noble.
+
+        No new tests, the flat was unused except in an existing test that was removed.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::restrictionNames):
+        (WebCore::MediaElementSession::effectivePreloadForElement const):
+        * html/MediaElementSession.h:
+        * platform/graphics/cg/UTIRegistry.cpp:
+        (WebCore::defaultSupportedImageTypes):
+        * testing/Internals.cpp:
+        (WebCore::Internals::setMediaElementRestrictions):
+
 2019-03-25  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -86 +86 @@
     CASE(WirelessVideoPlaybackDisabled)
     CASE(RequireUserGestureToAutoplayToExternalDevice)
-    CASE(MetadataPreloadingNotPermitted)
     CASE(AutoPreloadingNotPermitted)
     CASE(InvisibleAutoplayNotPermitted)
@@ -690 +689 @@
     if (pageExplicitlyAllowsElementToAutoplayInline(m_element))
         return preload;
-
-    if (m_restrictions & MetadataPreloadingNotPermitted)
-        return MediaPlayer::None;
 
     if (m_restrictions & AutoPreloadingNotPermitted) {

trunk/Source/WebCore/html/MediaElementSession.h

@@ -118 +118 @@
         WirelessVideoPlaybackDisabled =  1 << 7,
         RequireUserGestureToAutoplayToExternalDevice = 1 << 8,
-        MetadataPreloadingNotPermitted = 1 << 9,
         AutoPreloadingNotPermitted = 1 << 10,
         InvisibleAutoplayNotPermitted = 1 << 11,

trunk/Source/WebCore/testing/Internals.cpp

@@ -3851 +3851 @@
         if (equalLettersIgnoringASCIICase(restrictionString, "requireusergestureforaudioratechange"))
             restrictions |= MediaElementSession::RequireUserGestureForAudioRateChange;
-        if (equalLettersIgnoringASCIICase(restrictionString, "metadatapreloadingnotpermitted"))
-            restrictions |= MediaElementSession::MetadataPreloadingNotPermitted;
         if (equalLettersIgnoringASCIICase(restrictionString, "autopreloadingnotpermitted"))
             restrictions |= MediaElementSession::AutoPreloadingNotPermitted;