⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 243470 in webkit


Ignore:
Timestamp:
Mar 25, 2019, 4:18:48 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r243465.
​https://bugs.webkit.org/show_bug.cgi?id=196226

the test doesn't build (Requested by thorton on #webkit).

Reverted changeset:

"Do not terminate the NetworkProcess if a third party
application sends a NSCredential with a SecIdentityRef"
​https://bugs.webkit.org/show_bug.cgi?id=196213
​https://trac.webkit.org/changeset/243465

Location:
trunk
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r243469 r243470  
     12019-03-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r243465.
     4        https://bugs.webkit.org/show_bug.cgi?id=196226
     5
     6        the test doesn't build (Requested by thorton on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Do not terminate the NetworkProcess if a third party
     11        application sends a NSCredential with a SecIdentityRef"
     12        https://bugs.webkit.org/show_bug.cgi?id=196213
     13        https://trac.webkit.org/changeset/243465
     14
    1152019-03-25  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp

    r243465 r243470  
    698698bool decode(Decoder& decoder, RetainPtr<SecIdentityRef>& result)
    699699{
     700#if PLATFORM(COCOA)
     701    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessCredentials));
     702#endif
     703
    700704    RetainPtr<SecCertificateRef> certificate;
    701705    if (!decode(decoder, certificate))
    … …  
    712716    if (!decode(decoder, keyData))
    713717        return false;
    714 
    715 #if PLATFORM(COCOA)
    716     if (!hasProcessPrivilege(ProcessPrivilege::CanAccessCredentials))
    717         return true;
    718 #endif
    719718
    720719    SecKeyRef key = nullptr;

  • trunk/Tools/ChangeLog

    r243465 r243470  
     12019-03-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r243465.
     4        https://bugs.webkit.org/show_bug.cgi?id=196226
     5
     6        the test doesn't build (Requested by thorton on #webkit).
     7
     8        Reverted changeset:
     9
     10        "Do not terminate the NetworkProcess if a third party
     11        application sends a NSCredential with a SecIdentityRef"
     12        https://bugs.webkit.org/show_bug.cgi?id=196213
     13        https://trac.webkit.org/changeset/243465
     14
    1152019-03-25  Alex Christensen  <achristensen@webkit.org>
    216

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r243465 r243470  
    312312                5C0BF8951DD599CD00B00328 /* NavigatorLanguage.mm in Sources */ = {isa = PBXBuildFile; fileRef = E19DB9781B32137C00DB38D4 /* NavigatorLanguage.mm */; };
    313313                5C19A5241FD0F60100EEA323 /* CookiePrivateBrowsing.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C19A5231FD0F32600EEA323 /* CookiePrivateBrowsing.mm */; };
    314                 5C23DF0B2246015800F454B6 /* Challenge.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C23DF0A2245C9D700F454B6 /* Challenge.mm */; };
    315314                5C2936931D5BF70D00DEAB1E /* CookieAcceptPolicy.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C2936911D5BF63E00DEAB1E /* CookieAcceptPolicy.mm */; };
    316315                5C2936961D5C00ED00DEAB1E /* CookieMessage.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 5C2936941D5BFD1900DEAB1E /* CookieMessage.html */; };
    … …  
    17221721                5C0BF88F1DD5999B00B00328 /* WebViewCanPasteZeroPng.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebViewCanPasteZeroPng.mm; sourceTree = "<group>"; };
    17231722                5C19A5231FD0F32600EEA323 /* CookiePrivateBrowsing.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CookiePrivateBrowsing.mm; sourceTree = "<group>"; };
    1724                 5C23DF0A2245C9D700F454B6 /* Challenge.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = Challenge.mm; sourceTree = "<group>"; };
    17251723                5C2936911D5BF63E00DEAB1E /* CookieAcceptPolicy.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CookieAcceptPolicy.mm; sourceTree = "<group>"; };
    17261724                5C2936941D5BFD1900DEAB1E /* CookieMessage.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = CookieMessage.html; sourceTree = "<group>"; };
    … …  
    25332531                                1C2B817E1C891E4200A5529F /* CancelFontSubresource.mm */,
    25342532                                1C2B81811C891EFA00A5529F /* CancelFontSubresourcePlugIn.mm */,
    2535                                 5C23DF0A2245C9D700F454B6 /* Challenge.mm */,
    25362533                                5CB18BA71F5645B200EE23C4 /* ClickAutoFillButton.mm */,
    25372534                                CDF92236216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm */,
    … …  
    40304027                                57303BC9200824D300355965 /* CBORValueTest.cpp in Sources */,
    40314028                                57303BCA20082C0100355965 /* CBORWriterTest.cpp in Sources */,
    4032                                 5C23DF0B2246015800F454B6 /* Challenge.mm in Sources */,
    40334029                                F44A531221B8990A00DBB99C /* ClassMethodSwizzler.mm in Sources */,
    40344030                                7CCE7EE61A411AE600447C4C /* CloseFromWithinCreatePage.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.