Changeset 243479 in webkit

Timestamp:

Mar 25, 2019, 6:36:52 PM (7 years ago)

Author:

Fujii Hironori

Message:

Enable IPC sending and receiving non-default-constructible types
​https://bugs.webkit.org/show_bug.cgi?id=196132
<rdar://problem/49229221>

Unreviewed build fix for WinCairo port.

error C2440: '=': cannot convert from 'int' to 'HANDLE'

• Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::Handle): std::exchange HANDLE with nullptr, not 0.
(WebKit::SharedMemory::Handle::operator=): Ditto.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/win/SharedMemoryWin.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        Enable IPC sending and receiving non-default-constructible types
+        https://bugs.webkit.org/show_bug.cgi?id=196132
+        <rdar://problem/49229221>
+
+        Unreviewed build fix for WinCairo port.
+
+        error C2440: '=': cannot convert from 'int' to 'HANDLE'
+
+        * Platform/win/SharedMemoryWin.cpp:
+        (WebKit::SharedMemory::Handle::Handle): std::exchange HANDLE with nullptr, not 0.
+        (WebKit::SharedMemory::Handle::operator=): Ditto.
+
 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp

@@ -42 +42 @@
 SharedMemory::Handle::Handle(Handle&& other)
 {
-    m_handle = std::exchange(other.m_handle, 0);
+    m_handle = std::exchange(other.m_handle, nullptr);
     m_size = std::exchange(other.m_size, 0);
 }
@@ -48 +48 @@
 auto SharedMemory::Handle::operator=(Handle&& other) -> Handle&
 {
-    m_handle = std::exchange(other.m_handle, 0);
+    m_handle = std::exchange(other.m_handle, nullptr);
     m_size = std::exchange(other.m_size, 0);
     return *this;