Changeset 243484 in webkit

Timestamp:

Mar 25, 2019, 9:45:13 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

Remove some now-unnecessary dynamic class lookup
​https://bugs.webkit.org/show_bug.cgi?id=196237

Reviewed by Simon Fraser.

Source/WebKit:

• Shared/DocumentEditingContext.mm:

(WebKit::DocumentEditingContext::toPlatformContext):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(makeRequest):
(TEST):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/DocumentEditingContext.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-25  Tim Horton  <timothy_horton@apple.com>
+
+        Remove some now-unnecessary dynamic class lookup
+        https://bugs.webkit.org/show_bug.cgi?id=196237
+
+        Reviewed by Simon Fraser.
+
+        * Shared/DocumentEditingContext.mm:
+        (WebKit::DocumentEditingContext::toPlatformContext):
+
 2019-03-25  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/Shared/DocumentEditingContext.mm

@@ -43 +43 @@
 {
 #if HAVE(UI_WK_DOCUMENT_CONTEXT)
-    RetainPtr<UIWKDocumentContext> platformContext = adoptNS([[NSClassFromString(@"UIWKDocumentContext") alloc] init]);
+    auto platformContext = adoptNS([[UIWKDocumentContext alloc] init]);
 
     if (options.contains(DocumentEditingContextRequest::Options::AttributedText)) {

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-25  Tim Horton  <timothy_horton@apple.com>
+
+        Remove some now-unnecessary dynamic class lookup
+        https://bugs.webkit.org/show_bug.cgi?id=196237
+
+        Reviewed by Simon Fraser.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
+        (makeRequest):
+        (TEST):
+
 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm

@@ -60 +60 @@
 static UIWKDocumentRequest *makeRequest(UIWKDocumentRequestFlags flags, UITextGranularity granularity, NSInteger granularityCount, CGRect documentRect = CGRectZero, id <NSCopying> inputElementIdentifier = nil)
 {
-    RetainPtr<UIWKDocumentRequest> request = adoptNS([[NSClassFromString(@"UIWKDocumentRequest") alloc] init]);
+    auto request = adoptNS([[UIWKDocumentRequest alloc] init]);
     [request setFlags:flags];
     [request setSurroundingGranularity:granularity];
@@ -118 +118 @@
 TEST(WebKit, DocumentEditingContext)
 {
-    if (!NSClassFromString(@"UIWKDocumentRequest"))
-        return;
-
     RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);