Changeset 243485 in webkit

Timestamp:

Mar 25, 2019, 10:48:08 PM (7 years ago)

Author:

Chris Dumez

Message:

Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker
​https://bugs.webkit.org/show_bug.cgi?id=196205
<rdar://problem/49083324>

Reviewed by Geoffrey Garen.

Update our FileUploadPanel code on iOS to properly deal with the MIME types containing
wild cards (e.g. "image/*") that are defined in the HTML specification:

• ​https://html.spec.whatwg.org/multipage/input.html#attr-input-accept

Previously, we would fail to convert those to UTIs.

• UIProcess/ios/forms/WKFileUploadPanel.mm:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/forms/WKFileUploadPanel.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-25  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker
+        https://bugs.webkit.org/show_bug.cgi?id=196205
+        <rdar://problem/49083324>
+
+        Reviewed by Geoffrey Garen.
+
+        Update our FileUploadPanel code on iOS to properly deal with the MIME types containing
+        wild cards (e.g. "image/*") that are defined in the HTML specification:
+        - https://html.spec.whatwg.org/multipage/input.html#attr-input-accept
+
+        Previously, we would fail to convert those to UTIs.
+
+        * UIProcess/ios/forms/WKFileUploadPanel.mm:
+
 2019-03-25  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

@@ -319 +319 @@
     NSMutableSet *mediaTypes = [NSMutableSet set];
     for (NSString *mimeType in mimeTypes) {
-        auto uti = WebCore::UTIFromMIMEType(mimeType);
-        if (!uti.isEmpty())
-            [mediaTypes addObject:(__bridge NSString *)uti];
+        if ([mimeType caseInsensitiveCompare:@"image/*"] == NSOrderedSame)
+            [mediaTypes addObject:(__bridge NSString *)kUTTypeImage];
+        else if ([mimeType caseInsensitiveCompare:@"video/*"] == NSOrderedSame)
+            [mediaTypes addObject:(__bridge NSString *)kUTTypeMovie];
+        else if ([mimeType caseInsensitiveCompare:@"audio/*"] == NSOrderedSame)
+            [mediaTypes addObject:(__bridge NSString *)kUTTypeAudio];
+        else {
+            auto uti = WebCore::UTIFromMIMEType(mimeType);
+            if (!uti.isEmpty())
+                [mediaTypes addObject:(__bridge NSString *)uti];
+        }
     }
     return mediaTypes;