Changeset 243491 in webkit
- Timestamp:
- Mar 26, 2019, 4:18:29 AM (7 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
-
Source/WebKit/ChangeLog (modified) (1 diff)
-
Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp (modified) (8 diffs)
-
Source/WebKit/UIProcess/API/gtk/WebKitGeolocationManager.h (modified) (1 diff)
-
Source/WebKit/UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt (modified) (1 diff)
-
Source/WebKit/UIProcess/API/wpe/WebKitGeolocationManager.h (modified) (1 diff)
-
Source/WebKit/UIProcess/API/wpe/docs/wpe-1.0-sections.txt (modified) (1 diff)
-
Tools/ChangeLog (modified) (1 diff)
-
Tools/TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp (modified) (3 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r243490 r243491 1 2019-03-26 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 Unreviewed. Fix typo in GLib geolocation API after r243285. 4 5 gelocation -> geolocation. 6 7 * UIProcess/API/glib/WebKitGeolocationManager.cpp: 8 (webkit_geolocation_manager_class_init): 9 (webkit_geolocation_manager_update_position): 10 (webkit_geolocation_manager_failed): 11 (webkit_gelocation_manager_update_position): Deleted. 12 (webkit_gelocation_manager_failed): Deleted. 13 * UIProcess/API/gtk/WebKitGeolocationManager.h: 14 * UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: 15 * UIProcess/API/wpe/WebKitGeolocationManager.h: 16 * UIProcess/API/wpe/docs/wpe-1.0-sections.txt: 17 1 18 2019-03-26 Patrick Griffis <pgriffis@igalia.com> 2 19 -
trunk/Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp
r243409 r243491 42 42 * user location #WebKitGeolocationManager::start signal is emitted. If the signal is handled 43 43 * and returns %TRUE, the application is responsible for providing the position every time it's 44 * updated by calling webkit_ge location_manager_update_position(). The signal #WebKitGeolocationManager::stop44 * updated by calling webkit_geolocation_manager_update_position(). The signal #WebKitGeolocationManager::stop 45 45 * will be emitted when location updates are no longer needed. 46 46 * … … 88 88 * 89 89 * WebKitGeolocationPosition is an opaque struct used to provide position updates to a 90 * #WebKitGeolocationManager using webkit_ge location_manager_update_position().90 * #WebKitGeolocationManager using webkit_geolocation_manager_update_position(). 91 91 * 92 92 * Since: 2.26 … … 255 255 manager->priv->geoclueProvider->start([manager](GeolocationPosition&& corePosition, Optional<CString> error) { 256 256 if (error) { 257 webkit_ge location_manager_failed(manager, error->data());257 webkit_geolocation_manager_failed(manager, error->data()); 258 258 return; 259 259 } 260 260 261 261 WebKitGeolocationPosition position(WTFMove(corePosition)); 262 webkit_ge location_manager_update_position(manager, &position);262 webkit_geolocation_manager_update_position(manager, &position); 263 263 }); 264 264 } … … 360 360 * The signal is emitted to notify that @manager needs to start receiving 361 361 * position updates. After this signal is emitted the user should provide 362 * the updates using webkit_ge location_manager_update_position() every time363 * the position changes, or use webkit_ge location_manager_failed() in case362 * the updates using webkit_geolocation_manager_update_position() every time 363 * the position changes, or use webkit_geolocation_manager_failed() in case 364 364 * it isn't possible to determine the current position. 365 365 * … … 401 401 402 402 /** 403 * webkit_ge location_manager_update_position:403 * webkit_geolocation_manager_update_position: 404 404 * @manager: a #WebKitGeolocationManager 405 405 * @position: a #WebKitGeolocationPosition … … 409 409 * Since: 2.26 410 410 */ 411 void webkit_ge location_manager_update_position(WebKitGeolocationManager* manager, WebKitGeolocationPosition* position)411 void webkit_geolocation_manager_update_position(WebKitGeolocationManager* manager, WebKitGeolocationPosition* position) 412 412 { 413 413 g_return_if_fail(WEBKIT_IS_GEOLOCATION_MANAGER(manager)); … … 420 420 421 421 /** 422 * webkit_ge location_manager_failed:422 * webkit_geolocation_manager_failed: 423 423 * @manager: a #WebKitGeolocationManager 424 424 * @error_message: the error message … … 428 428 * Since: 2.26 429 429 */ 430 void webkit_ge location_manager_failed(WebKitGeolocationManager* manager, const char* errorMessage)430 void webkit_geolocation_manager_failed(WebKitGeolocationManager* manager, const char* errorMessage) 431 431 { 432 432 g_return_if_fail(WEBKIT_IS_GEOLOCATION_MANAGER(manager)); -
trunk/Source/WebKit/UIProcess/API/gtk/WebKitGeolocationManager.h
r243285 r243491 64 64 65 65 WEBKIT_API void 66 webkit_ge location_manager_update_position (WebKitGeolocationManager *manager,66 webkit_geolocation_manager_update_position (WebKitGeolocationManager *manager, 67 67 WebKitGeolocationPosition *position); 68 68 69 69 WEBKIT_API void 70 webkit_ge location_manager_failed (WebKitGeolocationManager *manager,70 webkit_geolocation_manager_failed (WebKitGeolocationManager *manager, 71 71 const char *error_message); 72 72 -
trunk/Source/WebKit/UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt
r243285 r243491 1498 1498 <FILE>WebKitGeolocationManager</FILE> 1499 1499 WebKitGeolocationManager 1500 webkit_ge location_manager_update_position1501 webkit_ge location_manager_failed1500 webkit_geolocation_manager_update_position 1501 webkit_geolocation_manager_failed 1502 1502 webkit_geolocation_manager_get_enable_high_accuracy 1503 1503 -
trunk/Source/WebKit/UIProcess/API/wpe/WebKitGeolocationManager.h
r243285 r243491 64 64 65 65 WEBKIT_API void 66 webkit_ge location_manager_update_position (WebKitGeolocationManager *manager,66 webkit_geolocation_manager_update_position (WebKitGeolocationManager *manager, 67 67 WebKitGeolocationPosition *position); 68 68 69 69 WEBKIT_API void 70 webkit_ge location_manager_failed (WebKitGeolocationManager *manager,70 webkit_geolocation_manager_failed (WebKitGeolocationManager *manager, 71 71 const char *error_message); 72 72 -
trunk/Source/WebKit/UIProcess/API/wpe/docs/wpe-1.0-sections.txt
r243285 r243491 1372 1372 <FILE>WebKitGeolocationManager</FILE> 1373 1373 WebKitGeolocationManager 1374 webkit_ge location_manager_update_position1375 webkit_ge location_manager_failed1374 webkit_geolocation_manager_update_position 1375 webkit_geolocation_manager_failed 1376 1376 webkit_geolocation_manager_get_enable_high_accuracy 1377 1377 -
trunk/Tools/ChangeLog
r243487 r243491 1 2019-03-26 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 Unreviewed. Fix typo in GLib geolocation API after r243285. 4 5 gelocation -> geolocation. 6 7 * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: 8 (testGeolocationManagerWatchPosition): 9 1 10 2019-03-25 Alex Christensen <achristensen@webkit.org> 2 11 -
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp
r243285 r243491 92 92 if (m_errorMessage) { 93 93 g_assert_false(m_checkPosition); 94 webkit_ge location_manager_failed(m_manager, m_errorMessage.get());94 webkit_geolocation_manager_failed(m_manager, m_errorMessage.get()); 95 95 } 96 96 97 97 if (m_checkPosition) { 98 98 g_assert_false(m_errorMessage.get()); 99 webkit_ge location_manager_update_position(m_manager, m_checkPosition);99 webkit_geolocation_manager_update_position(m_manager, m_checkPosition); 100 100 } 101 101 … … 308 308 309 309 WebKitGeolocationPosition* position = webkit_geolocation_position_new(37.1760783, -3.59033, 17); 310 webkit_ge location_manager_update_position(test->m_manager, position);310 webkit_geolocation_manager_update_position(test->m_manager, position); 311 311 webkit_geolocation_position_free(position); 312 312 auto result = test->lastPosition(); … … 316 316 317 317 position = webkit_geolocation_position_new(38.1770783, -3.60033, 17); 318 webkit_ge location_manager_update_position(test->m_manager, position);318 webkit_geolocation_manager_update_position(test->m_manager, position); 319 319 webkit_geolocation_position_free(position); 320 320 result = test->lastPosition();
Note:
See TracChangeset
for help on using the changeset viewer.