Changeset 243503 in webkit

Timestamp:

Mar 26, 2019, 10:27:05 AM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
​https://bugs.webkit.org/show_bug.cgi?id=196259
<rdar://problem/49240029>

Reviewed by Dean Jackson.

Source/WebCore:

Anonymous renderers don't have associated DOM nodes so they can't have event listeners either. Let's skip them.

Test: fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):

LayoutTests:

• fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt: Added.
• fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/ios/ContentChangeObserver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-26  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
+        https://bugs.webkit.org/show_bug.cgi?id=196259
+        <rdar://problem/49240029>
+
+        Reviewed by Dean Jackson.
+
+        * fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html: Added.
+
 2019-03-26  Shawn Roberts  <sroberts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-26  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
+        https://bugs.webkit.org/show_bug.cgi?id=196259
+        <rdar://problem/49240029>
+
+        Reviewed by Dean Jackson.
+
+        Anonymous renderers don't have associated DOM nodes so they can't have event listeners either. Let's skip them.
+
+        Test: fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html
+
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):
+
 2019-03-26  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -503 +503 @@
     ASSERT(m_element.renderer());
     for (auto& descendant : descendantsOfType<RenderElement>(*element.renderer())) {
+        if (!descendant.element())
+            continue;
         if (descendant.element()->willRespondToMouseClickEvents())
             return true;