Changeset 243550 in webkit

Timestamp:

Mar 27, 2019, 11:06:49 AM (7 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
​https://bugs.webkit.org/show_bug.cgi?id=196304
rdar://problem/49175760

Reviewed by Zalan Bujtas.

Source/WebCore:

repositionRelatedLayers() should not short-circuit when topContentInset is zero,
because topContentInset might be changing from non-zero to zero, and then we need
to move layers around.

Test: scrollingcoordinator/mac/top-content-inset-to-zero.html

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):

LayoutTests:

• scrollingcoordinator/mac/top-content-inset-to-zero-expected.html: Added.
• scrollingcoordinator/mac/top-content-inset-to-zero.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero-expected.html (added)
• LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-27  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
+        https://bugs.webkit.org/show_bug.cgi?id=196304
+        rdar://problem/49175760
+
+        Reviewed by Zalan Bujtas.
+
+        * scrollingcoordinator/mac/top-content-inset-to-zero-expected.html: Added.
+        * scrollingcoordinator/mac/top-content-inset-to-zero.html: Added.
+
 2019-03-27  Shawn Roberts  <sroberts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-27  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
+        https://bugs.webkit.org/show_bug.cgi?id=196304
+        rdar://problem/49175760
+
+        Reviewed by Zalan Bujtas.
+
+        repositionRelatedLayers() should not short-circuit when topContentInset is zero,
+        because topContentInset might be changing from non-zero to zero, and then we need
+        to move layers around.
+
+        Test: scrollingcoordinator/mac/top-content-inset-to-zero.html
+
+        * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+        (WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):
+
 2019-03-26  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm

@@ -212 +212 @@
 
     float topContentInset = this->topContentInset();
-    if (m_insetClipLayer && m_rootContentsLayer && topContentInset) {
+    if (m_insetClipLayer && m_rootContentsLayer) {
         m_insetClipLayer.get().position = FloatPoint(m_insetClipLayer.get().position.x, FrameView::yPositionForInsetClipLayer(scrollPosition, topContentInset));
         m_rootContentsLayer.get().position = FrameView::positionForRootContentLayer(scrollPosition, scrollOrigin(), topContentInset, headerHeight());