Changeset 243568 in webkit

Timestamp:

Mar 27, 2019, 4:32:34 PM (7 years ago)

Author:

Adrian Perez de Castro

Message:

Merged r243104 - REGRESSION(r236862): early frame decoupling leaves JSC ArrayBuffer objects lingering
​https://bugs.webkit.org/show_bug.cgi?id=195322

Reviewed by Ryosuke Niwa.

Since r236862, DOMWindow objects get disconnected from their Frame object as soon as
their iframe element gets removed from the document. Previously, DOMWindow was a
FrameDestructionObserver and would stay connected to its frame until the frame died.

This means that some of the work that we were doing in DOMWindow::frameDestroyed() and
Document::willDetachPage() no longer happens for subframe windows because they get
disconnected from their frame because they get a chance to get such notifications.
To address this issue, we now also do this work in DOMWindow::willDetachDocumentFromFrame()
which gets called when the iframe gets removed from the document and the document / window
get disconnected from the Frame element.

No new tests, verified locally that the leak is gone on JetStream.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::willDetachDocumentFromFrame):

Location:

releases/WebKitGTK/webkit-2.24/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-18  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION(r236862): early frame decoupling leaves JSC ArrayBuffer objects lingering
+        https://bugs.webkit.org/show_bug.cgi?id=195322
+
+        Reviewed by Ryosuke Niwa.
+
+        Since r236862, DOMWindow objects get disconnected from their Frame object as soon as
+        their iframe element gets removed from the document. Previously, DOMWindow was a
+        FrameDestructionObserver and would stay connected to its frame until the frame died.
+
+        This means that some of the work that we were doing in DOMWindow::frameDestroyed() and
+        Document::willDetachPage() no longer happens for subframe windows because they get
+        disconnected from their frame because they get a chance to get such notifications.
+        To address this issue, we now also do this work in DOMWindow::willDetachDocumentFromFrame()
+        which gets called when the iframe gets removed from the document and the document / window
+        get disconnected from the Frame element.
+
+        No new tests, verified locally that the leak is gone on JetStream.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::willDetachDocumentFromFrame):
+
 2019-03-12  Philippe Normand  <pnormand@igalia.com>
 

releases/WebKitGTK/webkit-2.24/Source/WebCore/page/DOMWindow.cpp

@@ -487 +487 @@
     if (m_performance)
         m_performance->clearResourceTimings();
+
+    JSDOMWindowBase::fireFrameClearedWatchpointsForWindow(this);
+    InspectorInstrumentation::frameWindowDiscarded(*frame(), this);
 }