Changeset 243595 in webkit

Timestamp:

Mar 27, 2019, 6:02:05 PM (7 years ago)

Author:

dino@apple.com

Message:

[ARKit] Black view when opening a 3D model usdz file in new tab
​https://bugs.webkit.org/show_bug.cgi?id=196333
<rdar://problem/47693367>

Reviewed by Tim Horton.

When opening a new WKSystemPreviewView, we were exiting if there was no
presentingViewController. This code was unnecessary, and causing blank
content when opening a new tab.

• UIProcess/ios/WKSystemPreviewView.mm:

(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
Remove the code looking for a presentingViewController.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKSystemPreviewView.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-27  Dean Jackson  <dino@apple.com>
+
+        [ARKit] Black view when opening a 3D model usdz file in new tab
+        https://bugs.webkit.org/show_bug.cgi?id=196333
+        <rdar://problem/47693367>
+
+        Reviewed by Tim Horton.
+
+        When opening a new WKSystemPreviewView, we were exiting if there was no
+        presentingViewController. This code was unnecessary, and causing blank
+        content when opening a new tab.
+
+        * UIProcess/ios/WKSystemPreviewView.mm:
+        (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
+        Remove the code looking for a presentingViewController.
+
 2019-03-27  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm

@@ -92 +92 @@
 - (void)web_setContentProviderData:(NSData *)data suggestedFilename:(NSString *)filename
 {
-    RefPtr<WebKit::WebPageProxy> page = _webView->_page;
-    UIViewController *presentingViewController = page->uiClient().presentingViewController();
-
-    if (!presentingViewController)
-        return;
-
     _suggestedFilename = adoptNS([filename copy]);
     _data = adoptNS([data copy]);