Changeset 243610 in webkit

Timestamp:

Mar 28, 2019, 11:05:13 AM (7 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
​https://bugs.webkit.org/show_bug.cgi?id=196352

Reviewed by Xabier Rodriguez-Calvar.

MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
branch is never reached.

This patch does not introduce behavior changes.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::doSeek):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-28  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
+        https://bugs.webkit.org/show_bug.cgi?id=196352
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
+        branch is never reached.
+
+        This patch does not introduce behavior changes.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::doSeek):
+
 2019-03-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -592 +592 @@
     MediaTime startTime = position, endTime = MediaTime::invalidTime();
 
-    // TODO: Should do more than that, need to notify the media source
-    // and probably flush the pipeline at least.
-    if (isMediaSource())
-        return true;
-
     if (rate < 0) {
         startTime = MediaTime::zeroTime();