Changeset 243624 in webkit

Timestamp:

Mar 28, 2019, 2:45:53 PM (7 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] imports-oom.js intermittently fails
​https://bugs.webkit.org/show_bug.cgi?id=196373

Reviewed by Saam Barati.

imports-oom.js ensures that a wasm module compilation / instantiation throws an OOM error instead of crashing when compiling / instantiating their entry points
with extremely low executable memory amount. And this test expects we at least once successfully compile, instantiate, and execute a wasm module to test that
wasm implementation is always throwing an OOM error. However, maybe due to wasm changes, the amount of executable memory consumed by wasm compilation is changed,
and now we may encounter an OOM error at the first compilation. Since imports-oom.js randomize the amount of executable memory used by the generated wasm module,
imports-oom.js intermittently fails when it first generates large wasm module which cannot be compiled.

This patch reduces the maxParams from 32 to 8 to reduce the size of randomly generated wasm module. Since we repeatedly generate wasm modules, this test soon encounter
an expected OOM error. But this avoids the situation that we get an OOM error when we compile a first wasm module.

• wasm/lowExecutableMemory/imports-oom.js:

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• wasm/lowExecutableMemory/imports-oom.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-03-28  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] imports-oom.js intermittently fails
+        https://bugs.webkit.org/show_bug.cgi?id=196373
+
+        Reviewed by Saam Barati.
+
+        imports-oom.js ensures that a wasm module compilation / instantiation throws an OOM error instead of crashing when compiling / instantiating their entry points
+        with extremely low executable memory amount. And this test expects we at least once successfully compile, instantiate, and execute a wasm module to test that
+        wasm implementation is always throwing an OOM error. However, maybe due to wasm changes, the amount of executable memory consumed by wasm compilation is changed,
+        and now we may encounter an OOM error at the first compilation. Since imports-oom.js randomize the amount of executable memory used by the generated wasm module,
+        imports-oom.js intermittently fails when it first generates large wasm module which cannot be compiled.
+
+        This patch reduces the maxParams from 32 to 8 to reduce the size of randomly generated wasm module. Since we repeatedly generate wasm modules, this test soon encounter
+        an expected OOM error. But this avoids the situation that we get an OOM error when we compile a first wasm module.
+
+        * wasm/lowExecutableMemory/imports-oom.js:
+
 2019-03-27  Saam Barati  <sbarati@apple.com>
 

trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js

@@ -4 +4 @@
 const verbose = false;
 const numFunctions = 2;
-const maxParams = 32;
+const maxParams = 8;
 
 // This test starts running with a few bytes of executable memory available. Try