Changeset 243647 in webkit

Timestamp:

Mar 29, 2019, 9:11:02 AM (7 years ago)

Author:

Michael Catanzaro

Message:

HTMLInputElement::setEditingValue should not fail if renderer doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=195708

Reviewed by Wenson Hsieh.

Source/WebCore:

HTMLInputElement::setEditingValue currently returns early if the element's renderer() is
null. This is causing the Epiphany password manager to fail to remember passwords on
​https://www.geico.com/ except for navigations through page cache.

This check was originally added to avoid some assertion, but I don't know which one, and
there's definitely not any assertion hit nowadays in this case. Probably there are more
guards checking if renderer() is null elsewhere in the code nowadays, closer to where it's
really needed.

Test: fast/forms/editing-value-null-renderer.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setEditingValue):

LayoutTests:

This is a copy of fast/forms/editing-value.html, except the form is not displayed. The input
value should still change.

• fast/forms/editing-value-null-renderer-expected.txt: Added.
• fast/forms/editing-value-null-renderer.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/editing-value-null-renderer-expected.txt (added)
• LayoutTests/fast/forms/editing-value-null-renderer.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-29  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        HTMLInputElement::setEditingValue should not fail if renderer doesn't exist
+        https://bugs.webkit.org/show_bug.cgi?id=195708
+
+        Reviewed by Wenson Hsieh.
+
+        This is a copy of fast/forms/editing-value.html, except the form is not displayed. The input
+        value should still change.
+
+        * fast/forms/editing-value-null-renderer-expected.txt: Added.
+        * fast/forms/editing-value-null-renderer.html: Added.
+
 2019-03-28  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-29  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        HTMLInputElement::setEditingValue should not fail if renderer doesn't exist
+        https://bugs.webkit.org/show_bug.cgi?id=195708
+
+        Reviewed by Wenson Hsieh.
+
+        HTMLInputElement::setEditingValue currently returns early if the element's renderer() is
+        null. This is causing the Epiphany password manager to fail to remember passwords on
+        https://www.geico.com/ except for navigations through page cache.
+
+        This check was originally added to avoid some assertion, but I don't know which one, and
+        there's definitely not any assertion hit nowadays in this case. Probably there are more
+        guards checking if renderer() is null elsewhere in the code nowadays, closer to where it's
+        really needed.
+
+        Test: fast/forms/editing-value-null-renderer.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setEditingValue):
+
 2019-03-29  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1037 +1037 @@
 void HTMLInputElement::setEditingValue(const String& value)
 {
-    if (!renderer() || !isTextField())
+    if (!isTextField())
         return;
+
     setInnerTextValue(value);
     subtreeHasChanged();