Changeset 243648 in webkit

Timestamp:

Mar 29, 2019, 10:44:14 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

WebKitTestRunner crashes when running pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
​https://bugs.webkit.org/show_bug.cgi?id=196345

Patch by Antoine Quint <Antoine Quint> on 2019-03-29
Reviewed by Dean Jackson.

An enum used within a WTF::OptionSet needs to have only power-of-two values that are larger than 0.

• platform/TouchAction.h:
• rendering/style/StyleRareNonInheritedData.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/TouchAction.h (modified) (1 diff)
• rendering/style/StyleRareNonInheritedData.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-29  Antoine Quint  <graouts@apple.com>
+
+        WebKitTestRunner crashes when running pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
+        https://bugs.webkit.org/show_bug.cgi?id=196345
+
+        Reviewed by Dean Jackson.
+
+        An enum used within a WTF::OptionSet needs to have only power-of-two values that are larger than 0.
+
+        * platform/TouchAction.h:
+        * rendering/style/StyleRareNonInheritedData.h:
+
 2019-03-29  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/platform/TouchAction.h

@@ -31 +31 @@
 
 enum class TouchAction : uint8_t {
-    Auto         = 0,
-    None         = 1 << 0,
-    Manipulation = 1 << 1,
-    PanX         = 1 << 2,
-    PanY         = 1 << 3,
-    PinchZoom    = 1 << 4,
+    Auto         = 1 << 0,
+    None         = 1 << 1,
+    Manipulation = 1 << 2,
+    PanX         = 1 << 3,
+    PanY         = 1 << 4,
+    PinchZoom    = 1 << 5,
 };
 

trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h

@@ -176 +176 @@
 
 #if ENABLE(POINTER_EVENTS)
-    unsigned touchActions : 5; // TouchAction
+    unsigned touchActions : 6; // TouchAction
 #endif