Changeset 243678 in webkit

Timestamp:

Mar 30, 2019, 7:09:23 AM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Add iFrame elements to the list of "considered clickable" elements.
​https://bugs.webkit.org/show_bug.cgi?id=196410
<rdar://problem/49436828>

Reviewed by Simon Fraser.

Source/WebCore:

163.com constructs an iFrame to display the login pane on hover. This patch ensures that we take iFrames into account while observing for visible content change by considering iFrame elements "clickable".
(While iFrames don't necessarily have clickable content, we can't just sit and wait until they are fully loaded.)

Test: fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):

LayoutTests:

• fast/events/touch/ios/content-observation/iframe-is-shown-on-hover-expected.txt: Added.
• fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/content-observation/iframe-is-shown-on-hover-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/ios/ContentChangeObserver.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-30  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Add iFrame elements to the list of "considered clickable" elements.
+        https://bugs.webkit.org/show_bug.cgi?id=196410
+        <rdar://problem/49436828>
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/touch/ios/content-observation/iframe-is-shown-on-hover-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html: Added.
+
 2019-03-30  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-30  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Add iFrame elements to the list of "considered clickable" elements.
+        https://bugs.webkit.org/show_bug.cgi?id=196410
+        <rdar://problem/49436828>
+
+        Reviewed by Simon Fraser.
+
+        163.com constructs an iFrame to display the login pane on hover. This patch ensures that we take iFrames into account while observing for visible content change by considering iFrame elements "clickable".
+        (While iFrames don't necessarily have clickable content, we can't just sit and wait until they are fully loaded.)
+
+        Test: fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html
+
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):
+
 2019-03-30  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -31 +31 @@
 #include "DOMTimer.h"
 #include "Document.h"
+#include "HTMLIFrameElement.h"
 #include "HTMLImageElement.h"
 #include "Logging.h"
@@ -487 +488 @@
 
     auto& element = const_cast<Element&>(m_element);
+    if (is<HTMLIFrameElement>(element))
+        return true;
+
     if (is<HTMLImageElement>(element)) {
         // This is required to avoid HTMLImageElement's touch callout override logic. See rdar://problem/48937767.