Changeset 243679 in webkit

Timestamp:

Mar 30, 2019, 9:38:17 AM (7 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
​https://bugs.webkit.org/show_bug.cgi?id=196419
<rdar://problem/49444023>

Reviewed by Devin Rousso.

• page/ResourceUsageThread.cpp:

(WebCore::ResourceUsageThread::addObserver):
We forgot to call the function that would setup platform state
allowing us to subtract out the sampling profiler thread.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/ResourceUsageThread.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-30  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
+        https://bugs.webkit.org/show_bug.cgi?id=196419
+        <rdar://problem/49444023>
+
+        Reviewed by Devin Rousso.
+
+        * page/ResourceUsageThread.cpp:
+        (WebCore::ResourceUsageThread::addObserver):
+        We forgot to call the function that would setup platform state
+        allowing us to subtract out the sampling profiler thread.
+
 2019-03-30  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/ResourceUsageThread.cpp

@@ -59 +59 @@
         resourceUsageThread.recomputeCollectionMode();
 
-        if (wasEmpty)
+        if (wasEmpty) {
+            resourceUsageThread.platformSaveStateBeforeStarting();
             resourceUsageThread.m_condition.notifyAll();
+        }
     }
 }