Changeset 243694 in webkit

Timestamp:

Apr 1, 2019, 9:38:03 AM (7 years ago)

Author:

Antti Koivisto

Message:

Trying to scroll the compose pane on gmail.com scrolls the message list behind
​https://bugs.webkit.org/show_bug.cgi?id=196426
<rdar://problem/49402667>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/scrolling/ios/event-region-visibility-hidden.html

We fail to gather event region from desdendants of non-overflowing elements with 'visibility:hidden'.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

Skip the subtree walk only if the current region covers the box already.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintList):

Remove the (wrong) optimization, we bail out quickly on first renderer if possible so this is not high value.

LayoutTests:

• fast/scrolling/ios/event-region-visibility-hidden-expected.txt: Added.
• fast/scrolling/ios/event-region-visibility-hidden.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/event-region-visibility-hidden-expected.txt (added)
• LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-01  Antti Koivisto  <antti@apple.com>
+
+        Trying to scroll the compose pane on gmail.com scrolls the message list behind
+        https://bugs.webkit.org/show_bug.cgi?id=196426
+        <rdar://problem/49402667>
+
+        Reviewed by Darin Adler.
+
+        * fast/scrolling/ios/event-region-visibility-hidden-expected.txt: Added.
+        * fast/scrolling/ios/event-region-visibility-hidden.html: Added.
+
 2019-04-01  Cathie Chen  <cathiechen@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-01  Antti Koivisto  <antti@apple.com>
+
+        Trying to scroll the compose pane on gmail.com scrolls the message list behind
+        https://bugs.webkit.org/show_bug.cgi?id=196426
+        <rdar://problem/49402667>
+
+        Reviewed by Darin Adler.
+
+        Test: fast/scrolling/ios/event-region-visibility-hidden.html
+
+        We fail to gather event region from desdendants of non-overflowing elements with 'visibility:hidden'.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::paintObject):
+
+        Skip the subtree walk only if the current region covers the box already.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::paintList):
+
+        Remove the (wrong) optimization, we bail out quickly on first renderer if possible so this is not high value.
+
 2019-04-01  Emilio Cobos Álvarez  <emilio@crisal.io>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -1249 +1249 @@
         }
 
-        // No need to check descendants if we don't have overflow.
-        if (!hasVisualOverflow())
+        // No need to check descendants if we don't have overflow and the area is already covered.
+        if (!hasVisualOverflow() && paintInfo.eventRegion->contains(enclosingIntRect(borderRect)))
             return;
     }

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -4489 +4489 @@
         return;
 
-    if (paintFlags.contains(PaintLayerCollectingEventRegion) && renderBox() && !renderBox()->hasRenderOverflow())
-        return;
-
 #if !ASSERT_DISABLED
     LayerListMutationDetector mutationChecker(*this);