Changeset 243709 in webkit

Timestamp:

Apr 1, 2019, 12:53:00 PM (7 years ago)

Author:

Antti Koivisto

Message:

Update event region when toggling pointer-events:none
​https://bugs.webkit.org/show_bug.cgi?id=195902
<rdar://problem/48988384>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/scrolling/ios/event-region-pointer-events.html

Normally paint invalidation requests compositing configuration update whenever anything that would
affect event region changes. However mutating 'pointer-events' property does not cause paint invalidation.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

Request compositing update explicitly from the containing layer.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::invalidateEventRegion):

• rendering/RenderLayer.h:

LayoutTests:

• fast/scrolling/ios/event-region-pointer-events-expected.txt: Added.
• fast/scrolling/ios/event-region-pointer-events.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/event-region-pointer-events-expected.txt (added)
• LayoutTests/fast/scrolling/ios/event-region-pointer-events.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderElement.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-01  Antti Koivisto  <antti@apple.com>
+
+        Update event region when toggling pointer-events:none
+        https://bugs.webkit.org/show_bug.cgi?id=195902
+        <rdar://problem/48988384>
+
+        Reviewed by Simon Fraser.
+
+        * fast/scrolling/ios/event-region-pointer-events-expected.txt: Added.
+        * fast/scrolling/ios/event-region-pointer-events.html: Added.
+
 2019-04-01  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-01  Antti Koivisto  <antti@apple.com>
+
+        Update event region when toggling pointer-events:none
+        https://bugs.webkit.org/show_bug.cgi?id=195902
+        <rdar://problem/48988384>
+
+        Reviewed by Simon Fraser.
+
+        Test: fast/scrolling/ios/event-region-pointer-events.html
+
+        Normally paint invalidation requests compositing configuration update whenever anything that would
+        affect event region changes. However mutating 'pointer-events' property does not cause paint invalidation.
+
+        * rendering/RenderElement.cpp:
+        (WebCore::RenderElement::styleWillChange):
+
+        Request compositing update explicitly from the containing layer.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::invalidateEventRegion):
+        * rendering/RenderLayer.h:
+
 2019-04-01  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderElement.cpp

@@ -731 +731 @@
         }
 
+        if (m_style.pointerEvents() != newStyle.pointerEvents()) {
+            // Usually the event region gets updated as a result of paint invalidation. Here we need to request an update explicitly.
+            if (auto* layer = enclosingLayer())
+                layer->invalidateEventRegion();
+        }
+
         if (m_parent && (newStyle.outlineSize() < m_style.outlineSize() || shouldRepaintForStyleDifference(diff)))
             repaint();

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -6663 +6663 @@
 }
 
+void RenderLayer::invalidateEventRegion()
+{
+    if (auto* compositingLayer = enclosingCompositingLayerForRepaint())
+        compositingLayer->setNeedsCompositingConfigurationUpdate();
+}
+
 TextStream& operator<<(TextStream& ts, const RenderLayer& layer)
 {

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -866 +866 @@
     WEBCORE_EXPORT bool isTransparentOrFullyClippedRespectingParentFrames() const;
 
+    void invalidateEventRegion();
+
 private: