Changeset 243717 in webkit

Timestamp:

Apr 1, 2019, 3:35:50 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
​https://bugs.webkit.org/show_bug.cgi?id=196271
<rdar://problem/49290676>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):

• Localizations/en.lproj/localizedStrings.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeBaseTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-01  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
+        https://bugs.webkit.org/show_bug.cgi?id=196271
+        <rdar://problem/49290676>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+        (WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
+
+        * Localizations/en.lproj/localizedStrings.js:
+
 2019-04-01  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -284 +284 @@
 localizedStrings["Copy Selected"] = "Copy Selected";
 localizedStrings["Copy Table"] = "Copy Table";
-localizedStrings["Copy as HTML"] = "Copy as HTML";
 localizedStrings["Copy as cURL"] = "Copy as cURL";
 localizedStrings["Could not fetch properties. Object may no longer exist."] = "Could not fetch properties. Object may no longer exist.";

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js

@@ -243 +243 @@
             return;
         }
-
-        if (resolvedValue.subtype === "node") {
-            contextMenu.appendItem(WI.UIString("Copy as HTML"), function() {
-                resolvedValue.pushNodeToFrontend(function(nodeId) {
-                    WI.domManager.nodeForId(nodeId).copyNode();
-                });
-            });
-
-            contextMenu.appendItem(WI.UIString("Scroll Into View"), function() {
-                function scrollIntoView() { this.scrollIntoViewIfNeeded(true); }
-                resolvedValue.callFunction(scrollIntoView, undefined, false, function() {});
-            });
-
-            contextMenu.appendSeparator();
-
-            contextMenu.appendItem(WI.UIString("Reveal in DOM Tree"), function() {
-                resolvedValue.pushNodeToFrontend(function(nodeId) {
-                    WI.domManager.inspectElement(nodeId);
-                });
-            });
-            return;
-        }
     }
 };