Changeset 243741 in webkit

Timestamp:

Apr 2, 2019, 7:47:41 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[GSteamer][WebRTC] Fix building libwebrtc on ARM
​https://bugs.webkit.org/show_bug.cgi?id=196157

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2019-04-02
Reviewed by Philippe Normand.

Making sure neon files are built as required

• CMakeLists.txt:

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• CMakeLists.txt (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt

@@ -305 +305 @@
     Source/third_party/libyuv/source/mjpeg_validate.cc
     Source/third_party/libyuv/source/planar_functions.cc
+    Source/third_party/libyuv/source/compare_neon.cc
+    Source/third_party/libyuv/source/compare_neon64.cc
     Source/third_party/libyuv/source/rotate.cc
     Source/third_party/libyuv/source/rotate_any.cc
@@ -310 +312 @@
     Source/third_party/libyuv/source/rotate_common.cc
     Source/third_party/libyuv/source/rotate_gcc.cc
+    Source/third_party/libyuv/source/rotate_neon.cc
+    Source/third_party/libyuv/source/rotate_neon64.cc
     Source/third_party/libyuv/source/row_any.cc
     Source/third_party/libyuv/source/row_common.cc
     Source/third_party/libyuv/source/row_gcc.cc
+    Source/third_party/libyuv/source/row_neon.cc
+    Source/third_party/libyuv/source/row_neon64.cc
     Source/third_party/libyuv/source/scale.cc
     Source/third_party/libyuv/source/scale_any.cc
@@ -318 +324 @@
     Source/third_party/libyuv/source/scale_common.cc
     Source/third_party/libyuv/source/scale_gcc.cc
+    Source/third_party/libyuv/source/scale_neon.cc
+    Source/third_party/libyuv/source/scale_neon64.cc
     Source/third_party/libyuv/source/video_common.cc
     Source/third_party/rnnoise/src/kiss_fft.cc
@@ -1394 +1402 @@
 )
 
+if (WTF_CPU_ARM)
+    target_compile_definitions(webrtc PRIVATE
+        WEBRTC_ARCH_ARM=1
+    )
+elseif (WTF_CPU_ARM64)
+    target_compile_definitions(webrtc PRIVATE
+        WEBRTC_ARCH_ARM64=1
+    )
+endif()
+
 target_include_directories(webrtc PRIVATE
     Source

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2019-04-02  Thibault Saunier  <tsaunier@igalia.com>
+
+        [GSteamer][WebRTC] Fix building libwebrtc on ARM
+        https://bugs.webkit.org/show_bug.cgi?id=196157
+
+        Reviewed by Philippe Normand.
+
+        Making sure neon files are built as required
+
+        * CMakeLists.txt:
+
 2019-03-22  Keith Rollin  <krollin@apple.com>