Changeset 243783 in webkit

Timestamp:

Apr 2, 2019, 6:56:58 PM (7 years ago)

Author:

Fujii Hironori

Message:

[WK2] Add support for Window's beforeprint / afterprint events
​https://bugs.webkit.org/show_bug.cgi?id=196478
<rdar://problem/49535124>

Unreviewed build fix for MSVC.

WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion

And, there is a style guideline. <​https://webkit.org/code-style-guidelines/#floating-point-literals>

• WebKitTestRunner/TestController.cpp:

(WTR::printFrame): Use int and float literals.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WK2] Add support for Window's beforeprint / afterprint events
+        https://bugs.webkit.org/show_bug.cgi?id=196478
+        <rdar://problem/49535124>
+
+        Unreviewed build fix for MSVC.
+
+        > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
+
+        And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::printFrame): Use int and float literals.
+
 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -265 +265 @@
 static void printFrame(WKPageRef page, WKFrameRef frame, const void*)
 {
-    WKPageBeginPrinting(page, frame, WKPrintInfo { 1.0, 21.0, 29.7 });
+    WKPageBeginPrinting(page, frame, WKPrintInfo { 1, 21, 29.7f });
     WKPageEndPrinting(page);
 }