Changeset 243810 in webkit

Timestamp:

Apr 3, 2019, 10:27:20 AM (7 years ago)

Author:

Chris Dumez

Message:

Remove legacy webkitRequestAnimationFrame time quirk
​https://bugs.webkit.org/show_bug.cgi?id=196458
<rdar://problem/49490207>

Reviewed by Simon Fraser.

Source/WebCore:

Remove legacy webkitRequestAnimationFrame time quirk and log a deprecation
warning whenever webkitRequestAnimationFrame is called.

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore::DOMWindow::webkitRequestAnimationFrame):

LayoutTests:

Rebaseline webkitRequestAnimationFrame layout test now that we log a deprecation
warning.

• fast/animation/request-animation-frame-prefix-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/RequestAnimationFrameCallback.h (modified) (1 diff)
• Source/WebCore/dom/ScriptedAnimationController.cpp (modified) (2 diffs)
• Source/WebCore/page/DOMWindow.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-03  Chris Dumez  <cdumez@apple.com>
+
+        Remove legacy webkitRequestAnimationFrame time quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196458
+        <rdar://problem/49490207>
+
+        Reviewed by Simon Fraser.
+
+        Rebaseline webkitRequestAnimationFrame layout test now that we log a deprecation
+        warning.
+
+        * fast/animation/request-animation-frame-prefix-expected.txt:
+
 2019-04-03  Alex Christensen  <achristensen@webkit.org>
 

trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 27: webkitRequestAnimationFrame() is deprecated and will be removed. Please use requestAnimationFrame() instead.
 Tests the timestamps provided to prefixed webkitRequestAnimationFrame callbacks
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-03  Chris Dumez  <cdumez@apple.com>
+
+        Remove legacy webkitRequestAnimationFrame time quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196458
+        <rdar://problem/49490207>
+
+        Reviewed by Simon Fraser.
+
+        Remove legacy webkitRequestAnimationFrame time quirk and log a deprecation
+        warning whenever webkitRequestAnimationFrame is called.
+
+        * dom/ScriptedAnimationController.cpp:
+        (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::requestAnimationFrame):
+        (WebCore::DOMWindow::webkitRequestAnimationFrame):
+
 2019-04-03  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/dom/RequestAnimationFrameCallback.h

@@ -45 +45 @@
     int m_id;
     bool m_firedOrCancelled;
-    bool m_useLegacyTimeBase;
 };
 

trunk/Source/WebCore/dom/ScriptedAnimationController.cpp

@@ -199 +199 @@
     // We round this to the nearest microsecond so that we can return a time that matches what is returned by document.timeline.currentTime.
     double highResNowMs = std::round(1000 * timestamp);
-    double legacyHighResNowMs = 1000 * (timestamp + m_document->loader()->timing().referenceWallTime().secondsSinceEpoch().seconds());
 
     // First, generate a list of callbacks to consider.  Callbacks registered from this point
@@ -214 +213 @@
             callback->m_firedOrCancelled = true;
             InspectorInstrumentationCookie cookie = InspectorInstrumentation::willFireAnimationFrame(protectedDocument, callback->m_id);
-            if (callback->m_useLegacyTimeBase)
-                callback->handleEvent(legacyHighResNowMs);
-            else
-                callback->handleEvent(highResNowMs);
+            callback->handleEvent(highResNowMs);
             InspectorInstrumentation::didFireAnimationFrame(cookie);
         }

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1696 +1696 @@
 int DOMWindow::requestAnimationFrame(Ref<RequestAnimationFrameCallback>&& callback)
 {
-    callback->m_useLegacyTimeBase = false;
     auto* document = this->document();
     if (!document)
@@ -1705 +1704 @@
 int DOMWindow::webkitRequestAnimationFrame(Ref<RequestAnimationFrameCallback>&& callback)
 {
-    callback->m_useLegacyTimeBase = true;
-    auto* document = this->document();
-    if (!document)
-        return 0;
-    return document->requestAnimationFrame(WTFMove(callback));
+    static bool firstTime = true;
+    if (firstTime && document()) {
+        document()->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, "webkitRequestAnimationFrame() is deprecated and will be removed. Please use requestAnimationFrame() instead."_s);
+        firstTime = false;
+    }
+    return requestAnimationFrame(WTFMove(callback));
 }