Changeset 243823 in webkit

Timestamp:

Apr 3, 2019, 1:27:12 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Status bubble should not display certain infrastructure status messages
​https://bugs.webkit.org/show_bug.cgi?id=196550

Reviewed by Lucas Forschler.

Do not display the steps which are un-needed for end-user. This information is still avaiable
if the user click on the bubble and look at the Buildbot build.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._steps_messages):
(StatusBubble._should_display_step): Method to decide whether to display the step or not.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -41 +41 @@
                     'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'wincairo', 'wpe']
     ENABLED_QUEUES = ['api-ios', 'api-mac', 'webkitperl']
+
+    STEPS_TO_HIDE = ['Killed old processes', 'Configured build', '^OS:.*Xcode:']
 
     def _build_bubble(self, patch, queue):
@@ -121 +123 @@
 
     def _steps_messages(self, build):
-        return '\n'.join([step.state_string for step in build.step_set.all()])
+        return '\n'.join([step.state_string for step in build.step_set.all() if self._should_display_step(step)])
+
+    def _should_display_step(self, step):
+        return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)
 
     def _most_recent_step_message(self, build):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-03  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status bubble should not display certain infrastructure status messages
+        https://bugs.webkit.org/show_bug.cgi?id=196550
+
+        Reviewed by Lucas Forschler.
+
+        Do not display the steps which are un-needed for end-user. This information is still avaiable
+        if the user click on the bubble and look at the Buildbot build.
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._steps_messages):
+        (StatusBubble._should_display_step): Method to decide whether to display the step or not.
+
 2019-04-03  Aakash Jain  <aakash_jain@apple.com>