Changeset 243853 in webkit

Timestamp:

Apr 3, 2019, 8:44:18 PM (7 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r243843.

Broke CLoop and Windows builds.

Reverted changeset:

"[JSC] Add dump feature for RandomizingFuzzerAgent"
​https://bugs.webkit.org/show_bug.cgi?id=196586
​https://trac.webkit.org/changeset/243843

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.cpp (modified) (1 diff)
• runtime/Options.h (modified) (1 diff)
• runtime/RandomizingFuzzerAgent.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-03  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r243843.
+
+        Broke CLoop and Windows builds.
+
+        Reverted changeset:
+
+        "[JSC] Add dump feature for RandomizingFuzzerAgent"
+        https://bugs.webkit.org/show_bug.cgi?id=196586
+        https://trac.webkit.org/changeset/243843
+
 2019-04-03  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.cpp

@@ -452 +452 @@
         || Options::verboseCFA()
         || Options::verboseDFGFailure()
-        || Options::verboseFTLFailure()
-        || Options::dumpRandomizingFuzzerAgentPredictions())
+        || Options::verboseFTLFailure())
         Options::alwaysComputeHash() = true;
     

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -437 +437 @@
     v(bool, useRandomizingFuzzerAgent, false, Normal, nullptr) \
     v(unsigned, seedOfRandomizingFuzzerAgent, 1, Normal, nullptr) \
-    v(bool, dumpRandomizingFuzzerAgentPredictions, false, Normal, nullptr) \
     \
     v(bool, logPhaseTimes, false, Normal, nullptr) \

trunk/Source/JavaScriptCore/runtime/RandomizingFuzzerAgent.cpp

@@ -34 +34 @@
 }
 
-SpeculatedType RandomizingFuzzerAgent::getPrediction(CodeBlock* codeBlock, int bytecodeIndex, SpeculatedType original)
+SpeculatedType RandomizingFuzzerAgent::getPrediction(CodeBlock*, int, SpeculatedType)
 {
     auto locker = holdLock(m_lock);
     uint32_t high = m_random.getUint32();
     uint32_t low = m_random.getUint32();
-    SpeculatedType generated = static_cast<SpeculatedType>((static_cast<uint64_t>(high) << 32) | low) & SpecFullTop;
-    if (Options::dumpRandomizingFuzzerAgentPredictions())
-        dataLogLn("getPrediction name:(", codeBlock->inferredName(), "#", codeBlock->hashAsStringIfPossible(), "),bytecodeIndex:(", bytecodeIndex, "),original:(", SpeculationDump(original), "),generated:(", SpeculationDump(generated), ")");
-    return generated;
+    uint64_t result = (static_cast<uint64_t>(high) << 32) | low;
+    return static_cast<SpeculatedType>(result) & SpecFullTop;
 }