Changeset 243862 in webkit

Timestamp:

Apr 3, 2019, 10:51:37 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded
​https://bugs.webkit.org/show_bug.cgi?id=196535

Reviewed by Michael Catanzaro.

This way the properties are not cached. Right now, if number of children is queried before the socket is
embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded.

• UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:

(webkitWebViewBaseAccessibleRefStateSet): Set ATK_STATE_TRANSIENT is the socket is not occupied.

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree): Unset ATK_STATE_TRANSIENT.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp (modified) (1 diff)
• UIProcess/gtk/WebPageProxyGtk.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded
+        https://bugs.webkit.org/show_bug.cgi?id=196535
+
+        Reviewed by Michael Catanzaro.
+
+        This way the properties are not cached. Right now, if number of children is queried before the socket is
+        embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded.
+
+        * UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:
+        (webkitWebViewBaseAccessibleRefStateSet): Set ATK_STATE_TRANSIENT is the socket is not occupied.
+        * UIProcess/gtk/WebPageProxyGtk.cpp:
+        (WebKit::WebPageProxy::bindAccessibilityTree): Unset ATK_STATE_TRANSIENT.
+
 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp

@@ -60 +60 @@
         // Use the implementation of AtkSocket if the widget is still alive.
         stateSet = ATK_OBJECT_CLASS(webkit_web_view_base_accessible_parent_class)->ref_state_set(atkObject);
+        if (!atk_socket_is_occupied(ATK_SOCKET(atkObject)))
+            atk_state_set_add_state(stateSet, ATK_STATE_TRANSIENT);
     } else {
         // If the widget is no longer alive, save some remote calls

trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp

@@ -60 +60 @@
     auto* accessible = gtk_widget_get_accessible(viewWidget());
     atk_socket_embed(ATK_SOCKET(accessible), const_cast<char*>(plugID.utf8().data()));
+    atk_object_notify_state_change(accessible, ATK_STATE_TRANSIENT, FALSE);
 }