Changeset 243874 in webkit

Timestamp:

Apr 4, 2019, 10:16:31 AM (7 years ago)

Author:

Ryan Haddad

Message:

Cherry-pick r241307. rdar://problem/49610758

AX: Fix flaky accessibility/loading-iframe-sends-notification.html
​https://bugs.webkit.org/show_bug.cgi?id=194546

Reviewed by Zalan Bujtas.

This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.

• accessibility/loading-iframe-sends-notification-expected.txt:
• accessibility/loading-iframe-sends-notification.html:

git-svn-id: ​http://svn.webkit.org/repository/webkit/trunk@241307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• accessibility/loading-iframe-sends-notification-expected.txt (modified) (1 diff)
• accessibility/loading-iframe-sends-notification.html (modified) (2 diffs)

branches/safari-607-branch/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-04  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Cherry-pick r241307. rdar://problem/49610758
+
+    AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+    https://bugs.webkit.org/show_bug.cgi?id=194546
+    
+    Reviewed by Zalan Bujtas.
+    
+    This test was relying on timing between load events being sent and accessibility events being sent.
+    We don't need to do that, we can more directly test this interplay.
+    
+    * accessibility/loading-iframe-sends-notification-expected.txt:
+    * accessibility/loading-iframe-sends-notification.html:
+    
+    
+    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@241307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-02-12  Chris Fleizach  <cfleizach@apple.com>
+
+            AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+            https://bugs.webkit.org/show_bug.cgi?id=194546
+
+            Reviewed by Zalan Bujtas.
+
+            This test was relying on timing between load events being sent and accessibility events being sent.
+            We don't need to do that, we can more directly test this interplay.
+
+            * accessibility/loading-iframe-sends-notification-expected.txt:
+            * accessibility/loading-iframe-sends-notification.html:
+
 2019-04-02  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt

@@ -14 +14 @@
 Got notification on iframe.
 PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
-PASS gotIframeNotification is true
 PASS successfullyParsed is true
 

branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification.html

@@ -43 +43 @@
     function runTest()
     {
-        window.gotIframeNotification = false;
-
         if (window.accessibilityController) {
             window.root = accessibilityController.rootElement;
@@ -60 +58 @@
 
                 debug("Got notification on iframe.");
-                gotIframeNotification = true;
 
                 // Check that the button within the iframe is now reachable from the root.
                 shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
+                accessibilityController.removeNotificationListener();
+                finishJSTest();
             });
         }
 
         window.iframeElement = document.getElementById("iframe");
-        iframeElement.addEventListener("load", function() {
-            window.setTimeout(function() {
-                shouldBeTrue("gotIframeNotification");
-                if (window.accessibilityController)
-                    accessibilityController.removeNotificationListener();
-
-                finishJSTest();
-            }, 10);
-        }, false);
 
         // Load content into the iframe. This will trigger the event