⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 243878 in webkit


Ignore:
Timestamp:
Apr 4, 2019, 10:39:32 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

[macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=189678
<rdar://problem/44621674>

Patch by Antoine Quint <Antoine Quint> on 2019-04-04
Reviewed by Dean Jackson.

We make the test sturdier by waiting for two rAFs instead of just one to wait until animations have been updated (one rAF)
and accelerated animations have been committed (two rAFs).

We also use the "transitioncancel" event to determine the transition has been interrupted rather than using a rAF callback.

  • webanimations/accelerated-transition-interrupted-on-composited-element.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r243872 r243878  
     12019-04-04  Antoine Quint  <graouts@apple.com>
     2
     3        [macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure
     4        https://bugs.webkit.org/show_bug.cgi?id=189678
     5        <rdar://problem/44621674>
     6
     7        Reviewed by Dean Jackson.
     8
     9        We make the test sturdier by waiting for two rAFs instead of just one to wait until animations have been updated (one rAF)
     10        and accelerated animations have been committed (two rAFs).
     11
     12        We also use the "transitioncancel" event to determine the transition has been interrupted rather than using a rAF callback.
     13
     14        * webanimations/accelerated-transition-interrupted-on-composited-element.html:
     15
    1162019-04-04  Diego Pino Garcia  <dpino@igalia.com>
    217

  • trunk/LayoutTests/webanimations/accelerated-transition-interrupted-on-composited-element.html

    r235991 r243878  
    1 <!DOCTYPE html><!-- webkit-test-runner [ experimental:WebAnimationsCSSIntegrationEnabled=true ] -->
     1<!DOCTYPE html>
    22<body>
    33<style>
    … …  
    1919div.addEventListener("transitionstart", event => {
    2020    div.style.transition = "none";
    21     if (window.testRunner)
    22         requestAnimationFrame(() => testRunner.notifyDone());
    2321});
     22
     23// When notified the transition was aborted, finish the test once we've ensured that animations
     24// have been updated (one rAF) and that accelerated animations will have been committed (two rAFs).
     25div.addEventListener("transitioncancel", event => {
     26    if (window.testRunner) {
     27        requestAnimationFrame(() => {
     28            requestAnimationFrame(() => testRunner.notifyDone());
     29        });
     30    }
     31});
     32
    2433
    2534// Initiate a transform transition.
Note: See TracChangeset for help on using the changeset viewer.