Changeset 243898 in webkit

Timestamp:

Apr 4, 2019, 1:41:57 PM (7 years ago)

Author:

ysuzuki@apple.com

Message:

Unreviewed, build fix for CLoop and Windows after r243886
​https://bugs.webkit.org/show_bug.cgi?id=196387

RegisterAtOffsetList does not exist if ENABLE(ASSEMBLER) is false.

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding):

• interpreter/StackVisitor.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/StackVisitor.cpp (modified) (2 diffs)
• interpreter/StackVisitor.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Unreviewed, build fix for CLoop and Windows after r243886
+        https://bugs.webkit.org/show_bug.cgi?id=196387
+
+        RegisterAtOffsetList does not exist if ENABLE(ASSEMBLER) is false.
+
+        * interpreter/StackVisitor.cpp:
+        (JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding):
+        * interpreter/StackVisitor.h:
+
 2019-04-04  Saam barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/interpreter/StackVisitor.cpp

@@ -254 +254 @@
 }
 
+#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
 Optional<RegisterAtOffsetList> StackVisitor::Frame::calleeSaveRegistersForUnwinding()
 {
     if (isInlinedFrame())
         return WTF::nullopt;
-
-#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
 
 #if ENABLE(WEBASSEMBLY)
@@ -280 +279 @@
         return *codeBlock->calleeSaveRegisters();
 
+    return WTF::nullopt;
+}
 #endif // !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
-
-    return WTF::nullopt;
-}
 
 String StackVisitor::Frame::functionName() const

trunk/Source/JavaScriptCore/interpreter/StackVisitor.h

@@ -95 +95 @@
         JS_EXPORT_PRIVATE void computeLineAndColumn(unsigned& line, unsigned& column) const;
 
+#if !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
         Optional<RegisterAtOffsetList> calleeSaveRegistersForUnwinding();
+#endif // !ENABLE(C_LOOP) && NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
 
         ClonedArguments* createArguments();