Changeset 243913 in webkit

Timestamp:

Apr 4, 2019, 3:42:43 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Status-bubble steps are sometimes displayed in reverse order
​https://bugs.webkit.org/show_bug.cgi?id=196625

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._steps_messages): Explicitly specify order_by('uid').

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -123 +123 @@
 
     def _steps_messages(self, build):
-        return '\n'.join([step.state_string for step in build.step_set.all() if self._should_display_step(step)])
+        return '\n'.join([step.state_string for step in build.step_set.all().order_by('uid') if self._should_display_step(step)])
 
     def _should_display_step(self, step):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-04  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status-bubble steps are sometimes displayed in reverse order
+        https://bugs.webkit.org/show_bug.cgi?id=196625
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._steps_messages): Explicitly specify order_by('uid').
+
 2019-04-04  Aakash Jain  <aakash_jain@apple.com>