⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 243921 in webkit


Ignore:
Timestamp:
Apr 4, 2019, 5:31:41 PM (7 years ago)
Author:
aakash_jain@apple.com
Message:

Add another status-bubble iframe to display results from new EWS
​https://bugs.webkit.org/show_bug.cgi?id=196308

Reviewed by Lucas Forschler.

  • js/status-bubble.js:

(handleStatusBubbleMessage): Added URL for new EWS.
(handleStatusBubbleLoadNewEWS): Method to post message to new EWS.

  • code-review.js: Added another iframe to display results from new EWS.
  • template/en/default/attachment/edit.html.tmpl: Ditto.
  • template/en/default/attachment/list.html.tmpl: Ditto.
  • template/en/default/attachment/reviewform.html.tmpl: Ditto.
Location:
trunk/Websites/bugs.webkit.org
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Websites/bugs.webkit.org/ChangeLog

    r240167 r243921  
     12019-04-04  Aakash Jain  <aakash_jain@apple.com>
     2
     3        Add another status-bubble iframe to display results from new EWS
     4        https://bugs.webkit.org/show_bug.cgi?id=196308
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * js/status-bubble.js:
     9        (handleStatusBubbleMessage): Added URL for new EWS.
     10        (handleStatusBubbleLoadNewEWS): Method to post message to new EWS.
     11        * code-review.js: Added another iframe to display results from new EWS.
     12        * template/en/default/attachment/edit.html.tmpl: Ditto.
     13        * template/en/default/attachment/list.html.tmpl: Ditto.
     14        * template/en/default/attachment/reviewform.html.tmpl: Ditto.
     15
    1162019-01-18  Ling Ho  <lingho@apple.com>
    217

  • trunk/Websites/bugs.webkit.org/code-review.js

    r235262 r243921  
    11// Copyright (C) 2010 Adam Barth. All rights reserved.
     2// Copyright (C) 2019 Apple Inc. All rights reserved.
    23//
    34// Redistribution and use in source and binary forms, with or without
    … …  
    574575      $('.statusBubble').append(statusBubble);
    575576
     577      var statusBubbleNewEWS = document.createElement('iframe');
     578      statusBubbleNewEWS.src  = 'https://ews.webkit.org/status-bubble/' + attachment_id + '/';
     579      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
     580      statusBubbleNewEWS.onload = function () { handleStatusBubbleLoadNewEWS(this); };
     581      $('.statusBubble').append(statusBubbleNewEWS);
     582
    576583      $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
    577584    });

  • trunk/Websites/bugs.webkit.org/js/status-bubble.js

    r235262 r243921  
    11/*
    22 * Copyright (C) 2018 Sony Interactive Entertainment Inc.
     3 * Copyright (C) 2019 Apple Inc. All rights reserved.
    34 *
    45 * Redistribution and use in source and binary forms, with or without
    … …  
    2526
    2627function handleStatusBubbleMessage(event) {
    27     if (event.origin !== 'https://webkit-queues.webkit.org' || !event.data.height)
     28    if ((event.origin !== 'https://webkit-queues.webkit.org' && event.origin !== 'https://ews.webkit.org') || !event.data.height)
    2829        return;
    2930
    … …  
    4041    iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
    4142}
     43
     44function handleStatusBubbleLoadNewEWS(iframe) {
     45    iframe.contentWindow.postMessage('containerMetrics', 'https://ews.webkit.org');
     46}

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl

    r235262 r243921  
    266266        <div class="statusBubble">
    267267          <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
    268                   style="width: 600px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
     268                  style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
     269          </iframe>
     270          <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]/"
     271                  style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoadNewEWS(this)">
    269272          </iframe>
    270273        </div>

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl

    r235262 r243921  
    157157          <div class="statusBubble">
    158158            <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
    159                     style="width: 600px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
     159                    style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this)">
     160            </iframe>
     161            <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]/"
     162                    style="width: 0px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoadNewEWS(this)">
    160163            </iframe>
    161164          </div>

  • trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl

    r214401 r243921  
    107107                style="width: 400px; height: 20px; border: none;" scrolling="no">
    108108        </iframe>
     109        <iframe src="https://ews.webkit.org/status-bubble/[% attachment.id %]/"
     110                style="width: 400px; height: 20px; border: none;" scrolling="no">
     111        </iframe>
    109112      </div>
    110113    </td>
Note: See TracChangeset for help on using the changeset viewer.