Changeset 243922 in webkit

Timestamp:

Apr 4, 2019, 5:49:40 PM (7 years ago)

Author:

ap@apple.com

Message:

Use a correct LC_RPATH when building with ASan
​https://bugs.webkit.org/show_bug.cgi?id=196576

Reviewed by David Kilzer.

• asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,

so that ../Frameworks is checked. This is simpler and more reliable than updating
each SPC service xcconfig.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• asan/asan.xcconfig (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-04  Alexey Proskuryakov  <ap@apple.com>
+
+        Use a correct LC_RPATH when building with ASan
+        https://bugs.webkit.org/show_bug.cgi?id=196576
+
+        Reviewed by David Kilzer.
+
+        * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
+        so that ../Frameworks is checked. This is simpler and more reliable than updating
+        each SPC service xcconfig.
+
 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/asan/asan.xcconfig

@@ -18 +18 @@
 ASAN_OTHER_CFLAGS = -fno-omit-frame-pointer -g;
 ASAN_OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CFLAGS);
+
+// Workaround for rdar://problem/49498092
+OTHER_LDFLAGS = $(inherited) $(WK_LDFLAGS_ASAN_$(ENABLE_ADDRESS_SANITIZER));
+WK_LDFLAGS_ASAN_YES = -Wl,-rpath,@executable_path/../Frameworks;