⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 243927 in webkit


Ignore:
Timestamp:
Apr 4, 2019, 11:42:05 PM (7 years ago)
Author:
Simon Fraser
Message:

Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
​https://bugs.webkit.org/show_bug.cgi?id=196635

Reviewed by Antti Koivisto.
Source/WebKit:

Remove WKBundleSetAsyncFrameScrollingEnabled().

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAsyncFrameScrollingEnabled): Deleted.

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
for a test to enable async frame scrolling via:

<!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->

so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.

Test: scrollingcoordinator/ios/programmatic-frame-scroll.html

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

  • scrollingcoordinator/ios/programmatic-frame-scroll-expected.html: Added.
  • scrollingcoordinator/ios/programmatic-frame-scroll.html: Added.
Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r243926 r243927  
     12019-04-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
     4        https://bugs.webkit.org/show_bug.cgi?id=196635
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * scrollingcoordinator/ios/programmatic-frame-scroll-expected.html: Added.
     9        * scrollingcoordinator/ios/programmatic-frame-scroll.html: Added.
     10
    1112019-04-04  Simon Fraser  <simon.fraser@apple.com>
    212

  • trunk/Source/WebKit/ChangeLog

    r243926 r243927  
     12019-04-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
     4        https://bugs.webkit.org/show_bug.cgi?id=196635
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Remove WKBundleSetAsyncFrameScrollingEnabled().
     9
     10        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
     11        (WKBundleSetAsyncFrameScrollingEnabled): Deleted.
     12        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
     13
    1142019-04-04  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp

    r243671 r243927  
    162162}
    163163
    164 void WKBundleSetAsyncFrameScrollingEnabled(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled)
    165 {
    166     WebKit::toImpl(bundleRef)->setAsyncFrameScrollingEnabled(WebKit::toImpl(pageGroupRef), enabled);
    167 }
    168 
    169164void WKBundleSetJavaScriptCanAccessClipboard(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled)
    170165{

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h

    r235851 r243927  
    4949WK_EXPORT void WKBundleSetMinimumLogicalFontSize(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, int size);
    5050WK_EXPORT void WKBundleSetFrameFlatteningEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
    51 WK_EXPORT void WKBundleSetAsyncFrameScrollingEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
    5251WK_EXPORT void WKBundleSetJavaScriptCanAccessClipboard(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
    5352WK_EXPORT void WKBundleSetPrivateBrowsingEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);

  • trunk/Tools/ChangeLog

    r243922 r243927  
     12019-04-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
     4        https://bugs.webkit.org/show_bug.cgi?id=196635
     5
     6        Reviewed by Antti Koivisto.
     7       
     8        InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
     9        for a test to enable async frame scrolling via:
     10            <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
     11        so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
     12       
     13        Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
     14
     15        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
     16        (WTR::InjectedBundle::beginTesting):
     17        * WebKitTestRunner/TestController.cpp:
     18        (WTR::TestController::resetPreferencesToConsistentValues):
     19
    1202019-04-04  Alexey Proskuryakov  <ap@apple.com>
    221

  • trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp

    r243666 r243927  
    478478#endif
    479479
     480    // Don't change experimental or internal features here; those should be set in TestController::resetPreferencesToConsistentValues().
    480481    WKBundleSetAllowUniversalAccessFromFileURLs(m_bundle, m_pageGroup, true);
    481482    WKBundleSetJavaScriptCanAccessClipboard(m_bundle, m_pageGroup, true);
    … …  
    484485    WKBundleSetAuthorAndUserStylesEnabled(m_bundle, m_pageGroup, true);
    485486    WKBundleSetFrameFlatteningEnabled(m_bundle, m_pageGroup, false);
    486     WKBundleSetAsyncFrameScrollingEnabled(m_bundle, m_pageGroup, false);
    487487    WKBundleSetMinimumLogicalFontSize(m_bundle, m_pageGroup, 9);
    488488    WKBundleSetSpatialNavigationEnabled(m_bundle, m_pageGroup, false);

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r243911 r243927  
    756756
    757757    WKPreferencesResetAllInternalDebugFeatures(preferences);
     758
    758759    // Set internal features that have different default values for testing.
    759760    static WKStringRef asyncOverflowScrollingFeature = WKStringCreateWithUTF8CString("AsyncOverflowScrollingEnabled");
    760761    WKPreferencesSetInternalDebugFeatureForKey(preferences, false, asyncOverflowScrollingFeature);
     762
     763    static WKStringRef asyncFrameScrollingFeature = WKStringCreateWithUTF8CString("AsyncFrameScrollingEnabled");
     764    WKPreferencesSetInternalDebugFeatureForKey(preferences, false, asyncFrameScrollingFeature);
    761765
    762766    for (const auto& internalDebugFeature : options.internalDebugFeatures)
Note: See TracChangeset for help on using the changeset viewer.