Changeset 243951 in webkit

Timestamp:

Apr 5, 2019, 4:06:46 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Undeprecate WKNavigationData
​https://bugs.webkit.org/show_bug.cgi?id=196559
<rdar://44927425>

Reviewed by Geoff Garen.

• UIProcess/API/Cocoa/WKNavigationData.h:

It is used to communicate information from FrameLoaderClient::updateGlobalHistory() to the application.
This use in WKBrowsingContextHistoryDelegate is definitely still deprecated, but its use in
WKHistoryDelegatePrivate does not have an adequate replacement yet, so it must remain undeprecated SPI.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/Cocoa/APIObject.mm (modified) (1 diff)
• UIProcess/API/Cocoa/WKNavigationData.h (modified) (1 diff)
• UIProcess/API/Cocoa/WKNavigationData.mm (modified) (1 diff)
• UIProcess/API/Cocoa/WKNavigationDataInternal.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-05  Alex Christensen  <achristensen@webkit.org>
+
+        Undeprecate WKNavigationData
+        https://bugs.webkit.org/show_bug.cgi?id=196559
+        <rdar://44927425>
+
+        Reviewed by Geoff Garen.
+
+        * UIProcess/API/Cocoa/WKNavigationData.h:
+        It is used to communicate information from FrameLoaderClient::updateGlobalHistory() to the application.
+        This use in WKBrowsingContextHistoryDelegate is definitely still deprecated, but its use in
+        WKHistoryDelegatePrivate does not have an adequate replacement yet, so it must remain undeprecated SPI.
+
 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebKit/Shared/Cocoa/APIObject.mm

@@ -257 +257 @@
 
     case Type::NavigationData:
-        ALLOW_DEPRECATED_DECLARATIONS_BEGIN
         wrapper = [WKNavigationData alloc];
-        ALLOW_DEPRECATED_DECLARATIONS_END
         break;
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.h

@@ -32 +32 @@
 #import <Foundation/Foundation.h>
 
-WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKNavigation", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))
+WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
 @interface WKNavigationData : NSObject
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm

@@ -31 +31 @@
 #import <WebCore/ResourceResponse.h>
 
-IGNORE_WARNINGS_BEGIN("deprecated-implementations")
 @implementation WKNavigationData {
-IGNORE_WARNINGS_END
     API::ObjectStorage<API::NavigationData> _data;
 }

trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDataInternal.h

@@ -32 +32 @@
 
 template<> struct WrapperTraits<API::NavigationData> {
-    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     using WrapperClass = WKNavigationData;
-    ALLOW_DEPRECATED_DECLARATIONS_END
 };