Changeset 243964 in webkit

Timestamp:

Apr 6, 2019, 7:54:58 PM (7 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION(r237196): Web Inspector: Computed panel shouldn't update when it isn't visible
​https://bugs.webkit.org/show_bug.cgi?id=196667
<rdar://problem/49664912>

Reviewed by Timothy Hatcher.

Explicitly define hidden and shown methods instead of relying on SidebarPanel's visible getter.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype.visibilityDidChange): Deleted.
(WI.GeneralStyleDetailsSidebarPanel.prototype.hidden): Added.
(WI.GeneralStyleDetailsSidebarPanel.prototype.shown): Added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-06  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION(r237196): Web Inspector: Computed panel shouldn't update when it isn't visible
+        https://bugs.webkit.org/show_bug.cgi?id=196667
+        <rdar://problem/49664912>
+
+        Reviewed by Timothy Hatcher.
+
+        Explicitly define `hidden` and `shown` methods instead of relying on SidebarPanel's `visible` getter.
+
+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+        (WI.GeneralStyleDetailsSidebarPanel.prototype.visibilityDidChange): Deleted.
+        (WI.GeneralStyleDetailsSidebarPanel.prototype.hidden): Added.
+        (WI.GeneralStyleDetailsSidebarPanel.prototype.shown): Added.
+
 2019-04-05  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js

@@ -46 +46 @@
     }
 
-    visibilityDidChange()
-    {
-        super.visibilityDidChange();
+    hidden()
+    {
+        super.hidden();
+
+        if (this._panel)
+            this._panel.hidden();
+    }
+
+    shown()
+    {
+        super.shown();
 
         if (!this._panel)
             return;
 
-        if (!this.visible) {
-            this._panel.hidden();
-            return;
-        }
+        console.assert(this.visible, `Shown panel ${this._identifier} must be visible.`);
 
         this._updateNoForcedPseudoClassesScrollOffset();
-
         this._panel.shown();
         this._panel.markAsNeedsRefresh(this.domNode);