Changeset 243969 in webkit

Timestamp:

Apr 7, 2019, 7:58:26 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r243956.
​https://bugs.webkit.org/show_bug.cgi?id=196688

Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
by aakashjain on #webkit).

Reverted changeset:

"Clicking "Go Back" from a safe browsing warning from an
iframe should navigate the WKWebView back to the previous
page"
​https://bugs.webkit.org/show_bug.cgi?id=196665
​https://trac.webkit.org/changeset/243956

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)
• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (modified) (5 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r243956.
+        https://bugs.webkit.org/show_bug.cgi?id=196688
+
+        Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
+        by aakashjain on #webkit).
+
+        Reverted changeset:
+
+        "Clicking "Go Back" from a safe browsing warning from an
+        iframe should navigate the WKWebView back to the previous
+        page"
+        https://bugs.webkit.org/show_bug.cgi?id=196665
+        https://trac.webkit.org/changeset/243956
+
 2019-04-07  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -1356 +1356 @@
         if (!strongSelf)
             return;
-        bool navigatesFrame = WTF::switchOn(result,
+        bool navigatesMainFrame = WTF::switchOn(result,
             [] (WebKit::ContinueUnsafeLoad continueUnsafeLoad) { return continueUnsafeLoad == WebKit::ContinueUnsafeLoad::Yes; },
             [] (const URL&) { return true; }
         );
-        bool forMainFrameNavigation = [strongSelf->_safeBrowsingWarning forMainFrameNavigation];
-        if (navigatesFrame && forMainFrameNavigation) {
-            // The safe browsing warning will be hidden once the next page is shown.
+        if (navigatesMainFrame && [strongSelf->_safeBrowsingWarning forMainFrameNavigation])
             return;
-        }
-        if (!navigatesFrame && strongSelf->_safeBrowsingWarning && !forMainFrameNavigation) {
-            [strongSelf goBack];
-            return;
-        }
         [std::exchange(strongSelf->_safeBrowsingWarning, nullptr) removeFromSuperview];
     }]);

trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm

@@ -1588 +1588 @@
         if (!weakThis)
             return;
-        bool navigatesFrame = WTF::switchOn(result,
+        bool navigatesMainFrame = WTF::switchOn(result,
             [] (ContinueUnsafeLoad continueUnsafeLoad) { return continueUnsafeLoad == ContinueUnsafeLoad::Yes; },
             [] (const URL&) { return true; }
         );
-        bool forMainFrameNavigation = [weakThis->m_safeBrowsingWarning forMainFrameNavigation];
-        if (navigatesFrame && forMainFrameNavigation) {
-            // The safe browsing warning will be hidden once the next page is shown.
+        if (navigatesMainFrame && [weakThis->m_safeBrowsingWarning forMainFrameNavigation])
             return;
-        }
-        if (!navigatesFrame && weakThis->m_safeBrowsingWarning && !forMainFrameNavigation) {
-            weakThis->m_page->goBack();
-            return;
-        }
         [std::exchange(weakThis->m_safeBrowsingWarning, nullptr) removeFromSuperview];
     }]);

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r243956.
+        https://bugs.webkit.org/show_bug.cgi?id=196688
+
+        Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
+        by aakashjain on #webkit).
+
+        Reverted changeset:
+
+        "Clicking "Go Back" from a safe browsing warning from an
+        iframe should navigate the WKWebView back to the previous
+        page"
+        https://bugs.webkit.org/show_bug.cgi?id=196665
+        https://trac.webkit.org/changeset/243956
+
 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm

@@ -221 +221 @@
 #endif
 
-template<typename ViewType> void goBack(ViewType *view, bool mainFrame = true)
+template<typename ViewType> void goBack(ViewType *view)
 {
     WKWebView *webView = (WKWebView *)view.superview;
     auto box = view.subviews.firstObject;
     checkTitleAndClick(box.subviews[3], "Go Back");
-    if (mainFrame)
-        EXPECT_EQ([webView _safeBrowsingWarning], nil);
-    else
-        EXPECT_NE([webView _safeBrowsingWarning], nil);
+    EXPECT_EQ([webView _safeBrowsingWarning], nil);
 }
 
@@ -372 +369 @@
 }
 
-static RetainPtr<NSString> phishingResourceName;
-
-@interface SimpleLookupContext : NSObject
-@end
-
-@implementation SimpleLookupContext
-
-+ (SimpleLookupContext *)sharedLookupContext
-{
-    static SimpleLookupContext *context = [[SimpleLookupContext alloc] init];
+@interface Simple3LookupContext : NSObject
+@end
+
+@implementation Simple3LookupContext
+
++ (Simple3LookupContext *)sharedLookupContext
+{
+    static Simple3LookupContext *context = [[Simple3LookupContext alloc] init];
     return context;
 }
@@ -388 +383 @@
 {
     BOOL phishing = NO;
-    if ([URL isEqual:resourceURL(phishingResourceName.get())])
+    if ([URL isEqual:resourceURL(@"simple3")])
         phishing = YES;
     completionHandler([TestLookupResult resultWithResults:@[[TestServiceLookupResult resultWithProvider:@"TestProvider" phishing:phishing malware:NO unwantedSoftware:NO]]], nil);
@@ -411 +406 @@
 TEST(SafeBrowsing, WKWebViewGoBack)
 {
-    phishingResourceName = @"simple3";
-    ClassMethodSwizzler swizzler(objc_getClass("SSBLookupContext"), @selector(sharedLookupContext), [SimpleLookupContext methodForSelector:@selector(sharedLookupContext)]);
+    ClassMethodSwizzler swizzler(objc_getClass("SSBLookupContext"), @selector(sharedLookupContext), [Simple3LookupContext methodForSelector:@selector(sharedLookupContext)]);
     
     auto delegate = adoptNS([WKWebViewGoBackNavigationDelegate new]);
@@ -434 +428 @@
 }
 
-TEST(SafeBrowsing, WKWebViewGoBackIFrame)
-{
-    phishingResourceName = @"simple";
-    ClassMethodSwizzler swizzler(objc_getClass("SSBLookupContext"), @selector(sharedLookupContext), [SimpleLookupContext methodForSelector:@selector(sharedLookupContext)]);
-    
-    auto delegate = adoptNS([WKWebViewGoBackNavigationDelegate new]);
-    auto webView = adoptNS([WKWebView new]);
-    [webView configuration].preferences._safeBrowsingEnabled = YES;
-    [webView setNavigationDelegate:delegate.get()];
-    [webView loadRequest:[NSURLRequest requestWithURL:resourceURL(@"simple2")]];
-    TestWebKitAPI::Util::run(&navigationFinished);
-    
-    [webView loadRequest:[NSURLRequest requestWithURL:resourceURL(@"simple-iframe")]];
-    while (![webView _safeBrowsingWarning])
-        TestWebKitAPI::Util::spinRunLoop();
-    navigationFinished = false;
-    goBack([webView _safeBrowsingWarning], false);
-    TestWebKitAPI::Util::run(&navigationFinished);
-    EXPECT_TRUE([[webView URL] isEqual:resourceURL(@"simple2")]);
-}
-
 @interface NullLookupContext : NSObject
 @end