Changeset 244044 in webkit

Timestamp:

Apr 8, 2019, 1:57:38 PM (7 years ago)

Author:

Ross Kirsling

Message:

-f[no-]var-tracking-assignments is GCC-only
​https://bugs.webkit.org/show_bug.cgi?id=196699

Reviewed by Don Olmstead.

• CMakeLists.txt:

Just remove the build flag altogether -- it supposedly doesn't solve the problem it was meant to
and said problem evidently no longer occurs as of GCC 9.

Location:

trunk/Source/JavaScriptCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/CMakeLists.txt

@@ -1272 +1272 @@
     # for e.g. parseInt depending on the platform and compilation flags.
     WEBKIT_ADD_TARGET_CXX_FLAGS(JavaScriptCore -ffp-contract=off)
-
-    # Avoid "variable tracking size limit exceeded"
-    set_source_files_properties(builtins/BuiltinNames.cpp PROPERTIES COMPILE_FLAGS -fno-var-tracking-assignments)
 endif ()
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-08  Ross Kirsling  <ross.kirsling@sony.com>
+
+        -f[no-]var-tracking-assignments is GCC-only
+        https://bugs.webkit.org/show_bug.cgi?id=196699
+
+        Reviewed by Don Olmstead.
+
+        * CMakeLists.txt:
+        Just remove the build flag altogether -- it supposedly doesn't solve the problem it was meant to
+        and said problem evidently no longer occurs as of GCC 9.
+
 2019-04-08  Saam Barati  <sbarati@apple.com>