Changeset 244074 in webkit

Timestamp:

Apr 9, 2019, 3:21:03 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Initialize trackTypeAsString for call to GST_INFO_OBJECT() in TrackType::Text
​https://bugs.webkit.org/show_bug.cgi?id=196350

Patch by Eike Rathke <​erack@redhat.com> on 2019-04-09
Reviewed by Xabier Rodriguez-Calvar.

trackTypeAsString was uninitialized in the
TrackPrivateBaseGStreamer::TrackType::Text case when calling
GST_INFO_OBJECT().

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::enableTrack):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-09  Eike Rathke  <erack@redhat.com>
+
+        Initialize trackTypeAsString for call to GST_INFO_OBJECT() in TrackType::Text
+        https://bugs.webkit.org/show_bug.cgi?id=196350
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        trackTypeAsString was uninitialized in the
+        TrackPrivateBaseGStreamer::TrackType::Text case when calling
+        GST_INFO_OBJECT().
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
+
 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -814 +814 @@
         break;
     case TrackPrivateBaseGStreamer::TrackType::Text:
+        propertyName = "current-text";
+        trackTypeAsString = "text";
         if (!selectedStreamId.isEmpty() && selectedStreamId == m_currentTextStreamId) {
             GST_INFO_OBJECT(pipeline(), "%s stream: %s already selected, not doing anything.", trackTypeAsString, selectedStreamId.utf8().data());
@@ -819 +821 @@
         }
 
-        propertyName = "current-text";
-        trackTypeAsString = "text";
         if (!m_currentAudioStreamId.isEmpty())
             selectedStreams.append(m_currentAudioStreamId);