Changeset 244082 in webkit

Timestamp:

Apr 9, 2019, 10:50:11 AM (7 years ago)

Author:

graouts@webkit.org

Message:

[ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure
​https://bugs.webkit.org/show_bug.cgi?id=194798
<rdar://problem/48181898>

Reviewed by Dean Jackson.

When using the Web Animations engine, the best way to run code as an animation start is to use the "ready" promise, whereas
DOM events are dispatched asynchronously and, in the case of this test, might have an animation progress that is greater
than 0 and yield an animated transform that isn't quite the identity matrix.

• compositing/visible-rect/animated-from-none.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• compositing/visible-rect/animated-from-none.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-09  Antoine Quint  <graouts@apple.com>
+
+        [ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure
+        https://bugs.webkit.org/show_bug.cgi?id=194798
+        <rdar://problem/48181898>
+
+        Reviewed by Dean Jackson.
+
+        When using the Web Animations engine, the best way to run code as an animation start is to use the "ready" promise, whereas
+        DOM events are dispatched asynchronously and, in the case of this test, might have an animation progress that is greater
+        than 0 and yield an animated transform that isn't quite the identity matrix.
+
+        * compositing/visible-rect/animated-from-none.html:
+
 2019-04-09  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/compositing/visible-rect/animated-from-none.html

@@ -35 +35 @@
         function doTest()
         {
-            let animated = document.getElementById('animated');
-            animated.addEventListener('webkitAnimationStart', function() {
+            const animated = document.getElementById('animated');
+            animated.classList.add('animating');
+            animated.getAnimations()[0].ready.then(() => {
                 if (window.internals)
                     document.getElementById('layers').innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS)
@@ -42 +43 @@
                 if (window.testRunner)
                     testRunner.notifyDone();
-            }, false);
-            
-            animated.classList.add('animating');
+            });
         }
         window.addEventListener('load', doTest, false);