Changeset 244157 in webkit

Timestamp:

Apr 10, 2019, 3:47:26 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: Audit: result UI shown on first open if an audit was previously selected
​https://bugs.webkit.org/show_bug.cgi?id=196723
<rdar://problem/49722252>

Reviewed by Timothy Hatcher.

When opening Web Inspector for the first time, we will trigger resize layouts on the main
content area as Web Inspector is resized to it's old window size.

Rather than treating this layout as a View.LayoutReason.Resize, we should treat the
first layout (e.g. initialLayout) as a View.LayoutReason.Dirty instead, as there was
previously no content.

• UserInterface/Views/View.js:

(WI.View.prototype._layoutSubtree):
(WI.View.prototype._setLayoutReason):

• UserInterface/Views/AuditTestContentView.js:

(WI.AuditTestContentView):
Drive-by: ensure that this class is not instantiated directly.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/AuditTestContentView.js (modified) (1 diff)
• UserInterface/Views/View.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-10  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: Audit: result UI shown on first open if an audit was previously selected
+        https://bugs.webkit.org/show_bug.cgi?id=196723
+        <rdar://problem/49722252>
+
+        Reviewed by Timothy Hatcher.
+
+        When opening Web Inspector for the first time, we will trigger resize `layout`s on the main
+        content area as Web Inspector is resized to it's old window size.
+
+        Rather than treating this layout as a `View.LayoutReason.Resize`, we should treat the
+        first `layout` (e.g. `initialLayout`) as a `View.LayoutReason.Dirty` instead, as there was
+        previously no content.
+
+        * UserInterface/Views/View.js:
+        (WI.View.prototype._layoutSubtree):
+        (WI.View.prototype._setLayoutReason):
+
+        * UserInterface/Views/AuditTestContentView.js:
+        (WI.AuditTestContentView):
+        Drive-by: ensure that this class is not instantiated directly.
+
 2019-04-10  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js

@@ -32 +32 @@
         super(representedObject);
 
+        // This class should not be instantiated directly. Create a concrete subclass instead.
+        console.assert(this.constructor !== WI.AuditTestContentView && this instanceof WI.AuditTestContentView);
+
         this.element.classList.add("audit-test");
 

trunk/Source/WebInspectorUI/UserInterface/Views/View.js

@@ -277 +277 @@
         let isInitialLayout = !this._didInitialLayout;
 
-        if (!this._didInitialLayout) {
+        if (isInitialLayout) {
+            // The initial layout should always be treated as dirty.
+            this._setLayoutReason();
+
             this.initialLayout();
             this._didInitialLayout = true;
@@ -302 +305 @@
     _setLayoutReason(layoutReason)
     {
-        if (this._layoutReason === WI.View.LayoutReason.Resize)
-            return;
-
         this._layoutReason = layoutReason || WI.View.LayoutReason.Dirty;
     }