⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 244174 in webkit


Ignore:
Timestamp:
Apr 10, 2019, 6:11:36 PM (7 years ago)
Author:
Alan Coon
Message:

Cherry-pick r243841. rdar://problem/49725678

-apple-trailing-word is needed for browser detection
​https://bugs.webkit.org/show_bug.cgi?id=196575

Unreviewed.

PerformanceTests:

  • MotionMark/resources/debug-runner/motionmark.css: (#intro .start-benchmark p):

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This is an unreviewed partial revert of r243819. Turns out there are some websites
which use this property to do browser detection. So, we need to continue to parse
the property, but we don't need the property to do anything.

Test: fast/text/trailing-word-detection.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TrailingWord const):
  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::trailingWord const): (WebCore::RenderStyle::setTrailingWord): (WebCore::RenderStyle::initialTrailingWord):
  • rendering/style/RenderStyleConstants.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/text/trailing-word-detection-expected.txt: Added.
  • fast/text/trailing-word-detection.html: Added.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-607-branch
Files:
2 added
24 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-607-branch/LayoutTests/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * fast/text/trailing-word-detection-expected.txt: Added.
     77            * fast/text/trailing-word-detection.html: Added.
     78            * platform/gtk/TestExpectations:
     79            * platform/win/TestExpectations:
     80
    1812019-04-10  Alan Coon  <alancoon@apple.com>
    282

  • branches/safari-607-branch/LayoutTests/platform/gtk/TestExpectations

    r244173 r244174  
    31593159webkit.org/b/160248 fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
    31603160webkit.org/b/160248 fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
     3161webkit.org/b/160248 fast/text/trailing-word-detection.html [ Failure ]
    31613162
    31623163webkit.org/b/160249 fast/shrink-wrap/rect-shrink-wrap.html [ ImageOnlyFailure ]

  • branches/safari-607-branch/LayoutTests/platform/win/TestExpectations

    r244173 r244174  
    30013001fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
    30023002fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
     3003fast/text/trailing-word-detection.html [ Failure ]
    30033004
    30043005# TestRunner::addChromeInputField() and focusWebView() not implemented

  • branches/safari-607-branch/PerformanceTests/ChangeLog

    r239438 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * MotionMark/resources/debug-runner/motionmark.css:
     77            (#intro .start-benchmark p):
     78
    1792018-12-20  Caio Lima  <ticaiolima@gmail.com>
    280

  • branches/safari-607-branch/PerformanceTests/MotionMark/resources/debug-runner/motionmark.css

    r233147 r244174  
    210210    color: hsl(11, 72%, 50%);
    211211    margin-bottom: 1em;
    212     -apple-trailing-word: -apple-partially-balanced;
    213212}
    214213

  • branches/safari-607-branch/Source/JavaScriptCore/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * Configurations/FeatureDefines.xcconfig:
     77
    1782019-04-10  Alan Coon  <alancoon@apple.com>
    279

  • branches/safari-607-branch/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);

  • branches/safari-607-branch/Source/WebCore/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            This is an unreviewed partial revert of r243819. Turns out there are some websites
     77            which use this property to do browser detection. So, we need to continue to parse
     78            the property, but we don't need the property to do anything.
     79
     80            Test: fast/text/trailing-word-detection.html
     81
     82            * Configurations/FeatureDefines.xcconfig:
     83            * css/CSSComputedStyleDeclaration.cpp:
     84            (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     85            * css/CSSPrimitiveValueMappings.h:
     86            (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     87            (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     88            * css/CSSProperties.json:
     89            * css/CSSValueKeywords.in:
     90            * css/parser/CSSParserFastPaths.cpp:
     91            (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     92            (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     93            * rendering/style/RenderStyle.h:
     94            (WebCore::RenderStyle::trailingWord const):
     95            (WebCore::RenderStyle::setTrailingWord):
     96            (WebCore::RenderStyle::initialTrailingWord):
     97            * rendering/style/RenderStyleConstants.h:
     98
    1992019-04-10  Alan Coon  <alancoon@apple.com>
    2100

  • branches/safari-607-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);

  • branches/safari-607-branch/Source/WebCore/PAL/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * Configurations/FeatureDefines.xcconfig:
     77
    1782019-04-10  Alan Coon  <alancoon@apple.com>
    279

  • branches/safari-607-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);

  • branches/safari-607-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r244173 r244174  
    39603960#endif
    39613961
     3962#if ENABLE(CSS_TRAILING_WORD)
     3963        case CSSPropertyAppleTrailingWord:
     3964            return cssValuePool.createValue(style.trailingWord());
     3965#endif
     3966
    39623967#if ENABLE(APPLE_PAY)
    39633968        case CSSPropertyApplePayButtonStyle:

  • branches/safari-607-branch/Source/WebCore/css/CSSPrimitiveValueMappings.h

    r244173 r244174  
    53855385#endif
    53865386
     5387#if ENABLE(CSS_TRAILING_WORD)
     5388template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TrailingWord e)
     5389    : CSSValue(PrimitiveClass)
     5390{
     5391    m_primitiveUnitType = CSS_VALUE_ID;
     5392    switch (e) {
     5393    case TrailingWord::Auto:
     5394        m_value.valueID = CSSValueAuto;
     5395        break;
     5396    case TrailingWord::PartiallyBalanced:
     5397        m_value.valueID = CSSValueWebkitPartiallyBalanced;
     5398        break;
     5399    default:
     5400        ASSERT_NOT_REACHED();
     5401        break;
     5402    }
     5403}
     5404
     5405template<> inline CSSPrimitiveValue::operator TrailingWord() const
     5406{
     5407    ASSERT(isValueID());
     5408    switch (m_value.valueID) {
     5409    case CSSValueAuto:
     5410        return TrailingWord::Auto;
     5411    case CSSValueWebkitPartiallyBalanced:
     5412        return TrailingWord::PartiallyBalanced;
     5413    default:
     5414        break;
     5415    }
     5416    ASSERT_NOT_REACHED();
     5417    return TrailingWord::Auto;
     5418}
     5419#endif
     5420
    53875421#if ENABLE(APPLE_PAY)
    53885422template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ApplePayButtonStyle e)

  • branches/safari-607-branch/Source/WebCore/css/CSSProperties.json

    r244173 r244174  
    67006700            "status": "non-standard"
    67016701        },
     6702        "-apple-trailing-word": {
     6703            "inherited": true,
     6704            "values": [
     6705                "auto",
     6706                "-webkit-partially-balanced"
     6707            ],
     6708            "codegen-properties": {
     6709                "name-for-methods": "TrailingWord",
     6710                "enable-if": "ENABLE_CSS_TRAILING_WORD"
     6711            },
     6712            "status": {
     6713                "status": "non-standard",
     6714                "comment": "Needed for feature-detecting the Safari browser. Implementation has no effect."
     6715            }
     6716        },
    67026717        "-apple-pay-button-style": {
    67036718            "codegen-properties": {

  • branches/safari-607-branch/Source/WebCore/css/CSSValueKeywords.in

    r244173 r244174  
    13241324from-intrinsic
    13251325
     1326#if defined(ENABLE_CSS_TRAILING_WORD) && ENABLE_CSS_TRAILING_WORD
     1327// -apple-trailing-word
     1328-webkit-partially-balanced
     1329#endif
     1330
    13261331#if defined(ENABLE_APPLE_PAY) && ENABLE_APPLE_PAY
    13271332// -apple-pay-button-style

  • branches/safari-607-branch/Source/WebCore/css/parser/CSSParserFastPaths.cpp

    r244173 r244174  
    762762    case CSSPropertyTouchAction: // auto | manipulation
    763763        return valueID == CSSValueAuto || valueID == CSSValueManipulation;
     764#endif
     765#if ENABLE(CSS_TRAILING_WORD)
     766    case CSSPropertyAppleTrailingWord: // auto | -apple-partially-balanced
     767        return valueID == CSSValueAuto || valueID == CSSValueWebkitPartiallyBalanced;
    764768#endif
    765769#if ENABLE(APPLE_PAY)
    … …  
    931935    // case CSSPropertyTextOrientation:
    932936    // case CSSPropertyUserSelect:
     937#if ENABLE(CSS_TRAILING_WORD)
     938    case CSSPropertyAppleTrailingWord:
     939#endif
    933940#if ENABLE(CSS_COMPOSITING)
    934941    case CSSPropertyIsolation:

  • branches/safari-607-branch/Source/WebCore/rendering/style/RenderStyle.h

    r244173 r244174  
    799799    bool shouldPlaceBlockDirectionScrollbarOnLeft() const;
    800800
     801#if ENABLE(CSS_TRAILING_WORD)
     802    TrailingWord trailingWord() const { return TrailingWord::Auto; }
     803#endif
     804
    801805#if ENABLE(APPLE_PAY)
    802806    ApplePayButtonStyle applePayButtonStyle() const { return static_cast<ApplePayButtonStyle>(m_rareNonInheritedData->applePayButtonStyle); }
    … …  
    12541258
    12551259    void setTextSecurity(TextSecurity security) { SET_VAR(m_rareInheritedData, textSecurity, static_cast<unsigned>(security)); }
     1260
     1261#if ENABLE(CSS_TRAILING_WORD)
     1262    void setTrailingWord(TrailingWord) { }
     1263#endif
    12561264
    12571265#if ENABLE(APPLE_PAY)
    … …  
    16221630#endif
    16231631
     1632#if ENABLE(CSS_TRAILING_WORD)
     1633    static TrailingWord initialTrailingWord() { return TrailingWord::Auto; }
     1634#endif
     1635
    16241636#if ENABLE(APPLE_PAY)
    16251637    static ApplePayButtonStyle initialApplePayButtonStyle() { return ApplePayButtonStyle::Black; }

  • branches/safari-607-branch/Source/WebCore/rendering/style/RenderStyleConstants.h

    r244173 r244174  
    11161116#endif
    11171117
     1118#if ENABLE(CSS_TRAILING_WORD)
     1119enum class TrailingWord : uint8_t {
     1120    Auto,
     1121    PartiallyBalanced
     1122};
     1123#endif
     1124
    11181125#if ENABLE(APPLE_PAY)
    11191126enum class ApplePayButtonStyle : uint8_t {

  • branches/safari-607-branch/Source/WebKit/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * Configurations/FeatureDefines.xcconfig:
     77
    1782019-04-10  Alan Coon  <alancoon@apple.com>
    279

  • branches/safari-607-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);

  • branches/safari-607-branch/Source/WebKitLegacy/mac/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * Configurations/FeatureDefines.xcconfig:
     77
    1782019-04-10  Alan Coon  <alancoon@apple.com>
    279

  • branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);

  • branches/safari-607-branch/Tools/ChangeLog

    r244173 r244174  
     12019-04-10  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r243841. rdar://problem/49725678
     4
     5    -apple-trailing-word is needed for browser detection
     6    https://bugs.webkit.org/show_bug.cgi?id=196575
     7   
     8    Unreviewed.
     9   
     10    PerformanceTests:
     11   
     12    * MotionMark/resources/debug-runner/motionmark.css:
     13    (#intro .start-benchmark p):
     14   
     15    Source/JavaScriptCore:
     16   
     17    * Configurations/FeatureDefines.xcconfig:
     18   
     19    Source/WebCore:
     20   
     21    This is an unreviewed partial revert of r243819. Turns out there are some websites
     22    which use this property to do browser detection. So, we need to continue to parse
     23    the property, but we don't need the property to do anything.
     24   
     25    Test: fast/text/trailing-word-detection.html
     26   
     27    * Configurations/FeatureDefines.xcconfig:
     28    * css/CSSComputedStyleDeclaration.cpp:
     29    (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
     30    * css/CSSPrimitiveValueMappings.h:
     31    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     32    (WebCore::CSSPrimitiveValue::operator TrailingWord const):
     33    * css/CSSProperties.json:
     34    * css/CSSValueKeywords.in:
     35    * css/parser/CSSParserFastPaths.cpp:
     36    (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     37    (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     38    * rendering/style/RenderStyle.h:
     39    (WebCore::RenderStyle::trailingWord const):
     40    (WebCore::RenderStyle::setTrailingWord):
     41    (WebCore::RenderStyle::initialTrailingWord):
     42    * rendering/style/RenderStyleConstants.h:
     43   
     44    Source/WebCore/PAL:
     45   
     46    * Configurations/FeatureDefines.xcconfig:
     47   
     48    Source/WebKit:
     49   
     50    * Configurations/FeatureDefines.xcconfig:
     51   
     52    Source/WebKitLegacy/mac:
     53   
     54    * Configurations/FeatureDefines.xcconfig:
     55   
     56    Tools:
     57   
     58    * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     59   
     60    LayoutTests:
     61   
     62    * fast/text/trailing-word-detection-expected.txt: Added.
     63    * fast/text/trailing-word-detection.html: Added.
     64    * platform/gtk/TestExpectations:
     65    * platform/win/TestExpectations:
     66   
     67    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     68
     69    2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
     70
     71            -apple-trailing-word is needed for browser detection
     72            https://bugs.webkit.org/show_bug.cgi?id=196575
     73
     74            Unreviewed.
     75
     76            * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     77
    1782019-04-10  Alan Coon  <alancoon@apple.com>
    279

  • branches/safari-607-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

    r244173 r244174  
    9393ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    9494
     95ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
     96
    9597ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
    9698
    … …  
    401403ENABLE_XSLT = ENABLE_XSLT;
    402404
    403 FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
     405FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Note: See TracChangeset for help on using the changeset viewer.