Changeset 244265 in webkit

Timestamp:

Apr 15, 2019, 10:23:26 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: Heap: snapshots taken manually don't appear in the list
​https://bugs.webkit.org/show_bug.cgi?id=196900
<rdar://problem/49880278>

Reviewed by Timothy Hatcher.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView):
(WI.HeapAllocationsTimelineView.prototype.layout):
(WI.HeapAllocationsTimelineView.prototype._importButtonNavigationItemClicked):
(WI.HeapAllocationsTimelineView.prototype._takeHeapSnapshotClicked):
Drive-by: only show heap snapshots for the selected range.

• UserInterface/Views/TimelineView.js:
• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._handleTimelineViewNeedsEntireSelectedRange): Added.
Drive-by: taking (or importing) a heap snapshot should select the entire range so that the
new record will appear in the list of heap snapshots.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/HeapAllocationsTimelineView.js (modified) (6 diffs)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (2 diffs)
• UserInterface/Views/TimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: Heap: snapshots taken manually don't appear in the list
+        https://bugs.webkit.org/show_bug.cgi?id=196900
+        <rdar://problem/49880278>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/HeapAllocationsTimelineView.js:
+        (WI.HeapAllocationsTimelineView):
+        (WI.HeapAllocationsTimelineView.prototype.layout):
+        (WI.HeapAllocationsTimelineView.prototype._importButtonNavigationItemClicked):
+        (WI.HeapAllocationsTimelineView.prototype._takeHeapSnapshotClicked):
+        Drive-by: only show heap snapshots for the selected range.
+
+        * UserInterface/Views/TimelineView.js:
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView):
+        (WI.TimelineRecordingContentView.prototype._handleTimelineViewNeedsEntireSelectedRange): Added.
+        Drive-by: taking (or importing) a heap snapshot should select the entire range so that the
+        new record will appear in the list of heap snapshots.
+
 2019-04-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js

@@ -94 +94 @@
         this._dataGrid.createSettings("heap-allocations-timeline-view");
         this._dataGrid.addEventListener(WI.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
-
+        this.setupDataGrid(this._dataGrid);
         this.addSubview(this._dataGrid);
 
@@ -263 +263 @@
     layout()
     {
-        if (this._pendingRecords.length && this.zeroTime) {
-            for (let heapAllocationsTimelineRecord of this._pendingRecords) {
-                this._dataGrid.addRowInSortOrder(new WI.HeapAllocationsTimelineDataGridNode(heapAllocationsTimelineRecord, {
-                    graphDataSource: this,
-                    heapAllocationsView: this,
-                }));
-            }
-
-            this._pendingRecords = [];
-            this._updateCompareHeapSnapshotButton();
-        }
+        super.layout();
+
+        if (!this._pendingRecords.length)
+            return;
+
+        for (let heapAllocationsTimelineRecord of this._pendingRecords) {
+            this._dataGrid.addRowInSortOrder(new WI.HeapAllocationsTimelineDataGridNode(heapAllocationsTimelineRecord, {
+                graphDataSource: this,
+                heapAllocationsView: this,
+            }));
+        }
+
+        this._pendingRecords = [];
+        this._updateCompareHeapSnapshotButton();
     }
 
@@ -381 +384 @@
     _importButtonNavigationItemClicked()
     {
-        WI.FileUtilities.importText(function(result) {
+        WI.FileUtilities.importText((result) => {
             let snapshotStringData = result.text;
             let workerProxy = WI.HeapSnapshotWorkerProxy.singleton();
@@ -389 +392 @@
                 const timestamp = NaN;
                 WI.timelineManager.heapSnapshotAdded(timestamp, snapshot);
+                this.dispatchEventToListeners(WI.TimelineView.Event.NeedsEntireSelectedRange);
             });
         });
@@ -395 +399 @@
     _takeHeapSnapshotClicked()
     {
-        HeapAgent.snapshot(function(error, timestamp, snapshotStringData) {
+        HeapAgent.snapshot((error, timestamp, snapshotStringData) => {
             let workerProxy = WI.HeapSnapshotWorkerProxy.singleton();
             workerProxy.createSnapshot(snapshotStringData, ({objectId, snapshot: serializedSnapshot}) => {
@@ -401 +405 @@
                 snapshot.snapshotStringData = snapshotStringData;
                 WI.timelineManager.heapSnapshotAdded(timestamp, snapshot);
+                this.dispatchEventToListeners(WI.TimelineView.Event.NeedsEntireSelectedRange);
             });
         });

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -115 +115 @@
         WI.TimelineView.addEventListener(WI.TimelineView.Event.ScannerShow, this._handleTimelineViewScannerShow, this);
         WI.TimelineView.addEventListener(WI.TimelineView.Event.ScannerHide, this._handleTimelineViewScannerHide, this);
+        WI.TimelineView.addEventListener(WI.TimelineView.Event.NeedsEntireSelectedRange, this._handleTimelineViewNeedsEntireSelectedRange, this);
 
         WI.notifications.addEventListener(WI.Notification.VisibilityStateDidChange, this._inspectorVisibilityStateChanged, this);
@@ -934 +935 @@
     }
 
+    _handleTimelineViewNeedsEntireSelectedRange(event)
+    {
+        if (!this.visible)
+            return;
+
+        this._timelineOverview.timelineRuler.selectEntireRange();
+    }
+
     _updateProgressView()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js

@@ -346 +346 @@
     ScannerShow: "timeline-view-scanner-show",
     ScannerHide: "timeline-view-scanner-hide",
+    NeedsEntireSelectedRange: "timeline-view-needs-entire-selected-range",
 };